[PR #94] [MERGED] implement disk "format" and "storage_type" fetch from API #224

New issue

Closed

opened 2026-02-28 00:41:16 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:16 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/94
Author: @yukron
Created: 10/22/2020
Status: ✅ Merged
Merged: 10/26/2020
Merged by: @ggongaware

Base: master ← Head: feature/added_getstoragestatus_api_request

📝 Commits (3)

efd5208 added GetStorageStatus call to API
ea7d048 added GetStorageContent API and disk format key
c9aac81 probing CheckVmRef for GetStorageStatus and GetStorageContent

📊 Changes

2 files changed (+65 additions, -6 deletions)

View changed files

📝 proxmox/client.go (+34 -0)
📝 proxmox/config_qemu.go (+31 -6)

📄 Description

This is to support terraform import to populate with actual disk parameters, right now both "format" and "storage_type" are only assigned on Create and Update.
PS: Yes, there are 2 additional API calls :) but not sure if it can be simplified.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/94 **Author:** [@yukron](https://github.com/yukron) **Created:** 10/22/2020 **Status:** ✅ Merged **Merged:** 10/26/2020 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `feature/added_getstoragestatus_api_request` --- ### 📝 Commits (3) - [`efd5208`](https://github.com/Telmate/proxmox-api-go/commit/efd5208529014e8d4f97252eb5bf473ff3782ee8) added GetStorageStatus call to API - [`ea7d048`](https://github.com/Telmate/proxmox-api-go/commit/ea7d048c898762b625f77ab7593b91fd2fadafc8) added GetStorageContent API and disk format key - [`c9aac81`](https://github.com/Telmate/proxmox-api-go/commit/c9aac8199bb62287eb3bc4749dd04d31690ad226) probing CheckVmRef for GetStorageStatus and GetStorageContent ### 📊 Changes **2 files changed** (+65 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+34 -0) 📝 `proxmox/config_qemu.go` (+31 -6) </details> ### 📄 Description This is to support `terraform import` to populate with actual disk parameters, right now both "format" and "storage_type" are only assigned on Create and Update. PS: Yes, there are 2 additional API calls :) but not sure if it can be simplified. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>