[PR #85] [MERGED] remove fatal logging in LXC API #218

New issue

Closed

opened 2026-02-28 00:41:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/85
Author: @hensur
Created: 7/27/2020
Status: ✅ Merged
Merged: 7/27/2020
Merged by: @ggongaware

Base: master ← Head: remove-fatal-logging

📝 Commits (1)

9e9b617 remove fatal logging in LXC API

📊 Changes

1 file changed (+2 additions, -9 deletions)

View changed files

📝 proxmox/config_lxc.go (+2 -9)

📄 Description

Hey,
I just found this client because I want to retrieve some information about my LXCs from the proxmox API.
However, I'd like to handle errors myself. I'd rather not have my whole program crash because some API request returned an error.

This PR removes the usage of log.Fatal and returns the error directly. I guess this also fixes #51

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/85 **Author:** [@hensur](https://github.com/hensur) **Created:** 7/27/2020 **Status:** ✅ Merged **Merged:** 7/27/2020 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `remove-fatal-logging` --- ### 📝 Commits (1) - [`9e9b617`](https://github.com/Telmate/proxmox-api-go/commit/9e9b617b383e7567105e168559f468d03eacdc5f) remove fatal logging in LXC API ### 📊 Changes **1 file changed** (+2 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_lxc.go` (+2 -9) </details> ### 📄 Description Hey, I just found this client because I want to retrieve some information about my LXCs from the proxmox API. However, I'd like to handle errors myself. I'd rather not have my whole program crash because some API request returned an error. This PR removes the usage of log.Fatal and returns the error directly. I guess this also fixes #51 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>