[PR #81] [MERGED] Added fix for optional volume key when parsing mountpoints #212

New issue

Closed

opened 2026-02-28 00:41:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/81
Author: @johnknott
Created: 7/11/2020
Status: ✅ Merged
Merged: 7/27/2020
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (1)

14f1afb Added fix for optional volume key when parsing mountpoints

📊 Changes

1 file changed (+5 additions, -0 deletions)

View changed files

📝 proxmox/config_lxc.go (+5 -0)

📄 Description

According to the docs at https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/lxc , the way mountpoints are specified includes a mandatory parameter with an option leading 'volume='.

So I think we have to be able to parse both of the following formats successfully:
a) "/mnt/pve/storage-box/,mp=/mnt/shared/" <Implied Volume definition>
b) "volume=/mnt/pve/storage-box/,mp=/mnt/shared/" <Explicit Volume definition>

I've see both formats of those definitions on my Proxmox machine. I'm not sure which are created by the UI, which by Terraform, which by pct set or which by pvesh.

Trying to parse mountpoint definitions like "/mnt/pve/storage-box/,mp=/mnt/shared/" was causing problems previously.

I've applied a small patch which should help other issues downstream like this one: https://github.com/Telmate/terraform-provider-proxmox/issues/157

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/81 **Author:** [@johnknott](https://github.com/johnknott) **Created:** 7/11/2020 **Status:** ✅ Merged **Merged:** 7/27/2020 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`14f1afb`](https://github.com/Telmate/proxmox-api-go/commit/14f1afbee0c1ae28b04e689fd840fa633c48a11c) Added fix for optional volume key when parsing mountpoints ### 📊 Changes **1 file changed** (+5 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_lxc.go` (+5 -0) </details> ### 📄 Description According to the docs at https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/lxc , the way mountpoints are specified includes a mandatory <volume> parameter with an option leading 'volume='. ```[volume=]<volume> ,mp=<Path> [,acl=<1|0>] [,backup=<1|0>] [,mountoptions=<opt[;opt...]>] [,quota=<1|0>] [,replicate=<1|0>] [,ro=<1|0>] [,shared=<1|0>] [,size=<DiskSize>]``` So I think we have to be able to parse both of the following formats successfully: a) `"/mnt/pve/storage-box/,mp=/mnt/shared/"` `<Implied Volume definition>` b) `"volume=/mnt/pve/storage-box/,mp=/mnt/shared/"` `<Explicit Volume definition>` I've see both formats of those definitions on my Proxmox machine. I'm not sure which are created by the UI, which by Terraform, which by `pct set` or which by `pvesh`. Trying to parse mountpoint definitions like `"/mnt/pve/storage-box/,mp=/mnt/shared/"` was causing problems previously. I've applied a small patch which should help other issues downstream like this one: https://github.com/Telmate/terraform-provider-proxmox/issues/157 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>