[PR #73] [MERGED] Wait for completion on upload #210

New issue

Closed

opened 2026-02-28 00:41:13 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/73
Author: @carlpett
Created: 1/4/2020
Status: ✅ Merged
Merged: 1/16/2020
Merged by: @ggongaware

Base: master ← Head: wait-for-upload-completion

📝 Commits (1)

d3b7e09 Wait for completion on upload

📊 Changes

1 file changed (+17 additions, -2 deletions)

View changed files

📝 proxmox/client.go (+17 -2)

📄 Description

When uploading files, Proxmox first saves them to a temporary location, and then moves them to the final directory. During the time it is moving the file, other API requests may fail. For big files, this can take several minutes.

This PR makes client.Upload wait for the move file task to finish before returning.

cc @ggongaware

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/73 **Author:** [@carlpett](https://github.com/carlpett) **Created:** 1/4/2020 **Status:** ✅ Merged **Merged:** 1/16/2020 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `wait-for-upload-completion` --- ### 📝 Commits (1) - [`d3b7e09`](https://github.com/Telmate/proxmox-api-go/commit/d3b7e09ec0a3fd88fb1545e6104234ca571aed52) Wait for completion on upload ### 📊 Changes **1 file changed** (+17 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+17 -2) </details> ### 📄 Description When uploading files, Proxmox first saves them to a temporary location, and then moves them to the final directory. During the time it is moving the file, other API requests may fail. For big files, this can take several minutes. This PR makes `client.Upload` wait for the move file task to finish before returning. cc @ggongaware --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>