[PR #74] [MERGED] Fix file descriptor leak in session.Do #208

New issue

Closed

opened 2026-02-28 00:41:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/74
Author: @carlpett
Created: 2/22/2020
Status: ✅ Merged
Merged: 2/25/2020
Merged by: @ggongaware

Base: master ← Head: fix-fd-leak

📝 Commits (1)

150277b Fix file descriptor leak in session.Do

📊 Changes

1 file changed (+10 additions, -0 deletions)

View changed files

📝 proxmox/session.go (+10 -0)

📄 Description

Currently session.Do leaks a file descriptor with every request, since we don't close the body. Thir PR makes sure the body will always be closed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/74 **Author:** [@carlpett](https://github.com/carlpett) **Created:** 2/22/2020 **Status:** ✅ Merged **Merged:** 2/25/2020 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `fix-fd-leak` --- ### 📝 Commits (1) - [`150277b`](https://github.com/Telmate/proxmox-api-go/commit/150277bc190445a2af8bf4222e0df72c79806fbc) Fix file descriptor leak in session.Do ### 📊 Changes **1 file changed** (+10 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/session.go` (+10 -0) </details> ### 📄 Description Currently `session.Do` leaks a file descriptor with every request, since we don't close the body. Thir PR makes sure the body will always be closed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>