[PR #60] [MERGED] Remove a fatal log to return an error #194

New issue

Closed

opened 2026-02-28 00:41:03 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:41:03 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/60
Author: @claudusd
Created: 10/29/2019
Status: ✅ Merged
Merged: 11/4/2019
Merged by: @ggongaware

Base: master ← Head: remove_fatal_log

📝 Commits (1)

94a05c2 Remove a fatal log to return an error

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 proxmox/config_qemu.go (+1 -1)

📄 Description

I replace the method Fatal by Print because the Fatal method do an os.Exit(1) and the lib stop and doesn't return the err.

Stopping the api client with an os.exit doesn't stop the promox provider properly.

The log.Fatal is use more than once in this library. If i have time (or someone else) i will do an other PR to clean it.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/60 **Author:** [@claudusd](https://github.com/claudusd) **Created:** 10/29/2019 **Status:** ✅ Merged **Merged:** 11/4/2019 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `remove_fatal_log` --- ### 📝 Commits (1) - [`94a05c2`](https://github.com/Telmate/proxmox-api-go/commit/94a05c222dd7e74356764b1d886694668e0fb776) Remove a fatal log to return an error ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/config_qemu.go` (+1 -1) </details> ### 📄 Description I replace the method ``Fatal`` by ``Print`` because the ``Fatal`` method do an ``os.Exit(1)`` and the lib stop and doesn't return the err. Stopping the api client with an ``os.exit`` doesn't stop the promox provider properly. The ``log.Fatal`` is use more than once in this library. If i have time (or someone else) i will do an other PR to clean it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>