[PR #36] [MERGED] Support setting pool on VmRef to create VMs in resource pools #173

New issue

Closed

opened 2026-02-28 00:40:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:40:58 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/36
Author: @carlpett
Created: 7/9/2019
Status: ✅ Merged
Merged: 7/10/2019
Merged by: @ggongaware

Base: master ← Head: pool-support

📝 Commits (1)

40079e4 Support setting pool on VmRef to create VMs in resource pools

📊 Changes

2 files changed (+12 additions, -0 deletions)

View changed files

📝 proxmox/client.go (+5 -0)
📝 proxmox/config_qemu.go (+7 -0)

📄 Description

This PR adds some early support for creating VMs in resource pools. I'm not super happy with having to if-check it like this, but the func for Create and Clone don't have a similar signature (create takes the node name string, while clone takes the full vmref) to centralize it without breaking APIs.

Also, I'm not sure if there are more places we should add it to?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/36 **Author:** [@carlpett](https://github.com/carlpett) **Created:** 7/9/2019 **Status:** ✅ Merged **Merged:** 7/10/2019 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `pool-support` --- ### 📝 Commits (1) - [`40079e4`](https://github.com/Telmate/proxmox-api-go/commit/40079e4a23cd7670cdfcd9fb1c7189e1c865b13b) Support setting pool on VmRef to create VMs in resource pools ### 📊 Changes **2 files changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+5 -0) 📝 `proxmox/config_qemu.go` (+7 -0) </details> ### 📄 Description This PR adds some early support for creating VMs in resource pools. I'm not super happy with having to if-check it like this, but the func for Create and Clone don't have a similar signature (create takes the node name string, while clone takes the full vmref) to centralize it without breaking APIs. Also, I'm not sure if there are more places we should add it to? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>