[PR #16] [MERGED] disks are now indexed from 0, fixes #15 #155

New issue

Closed

opened 2026-02-28 00:40:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:40:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/16
Author: @abuisine
Created: 12/27/2018
Status: ✅ Merged
Merged: 1/3/2019
Merged by: @ggongaware

Base: master ← Head: master

📝 Commits (4)

ddac899 disks are now indexed from 0, fixes #15
ebbefe6 raise a proper error while facing error http codes
f6fd47f raise proper error while facing non OK exitstatus
dc73194 API may take longer than 90s, extending to 300s (default in most Terraform plugins)

📊 Changes

3 files changed (+13 additions, -3 deletions)

View changed files

📝 proxmox/client.go (+6 -1)
📝 proxmox/config_qemu.go (+2 -2)
📝 proxmox/session.go (+5 -0)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/16 **Author:** [@abuisine](https://github.com/abuisine) **Created:** 12/27/2018 **Status:** ✅ Merged **Merged:** 1/3/2019 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`ddac899`](https://github.com/Telmate/proxmox-api-go/commit/ddac899fb81eab0fa2659bcee72ab11040f90419) disks are now indexed from 0, fixes #15 - [`ebbefe6`](https://github.com/Telmate/proxmox-api-go/commit/ebbefe6f213ddfa01dbb5ce29b1e79f1997f7fb7) raise a proper error while facing error http codes - [`f6fd47f`](https://github.com/Telmate/proxmox-api-go/commit/f6fd47fe9a787db0a4ff65a5ee72139535a6c01b) raise proper error while facing non OK exitstatus - [`dc73194`](https://github.com/Telmate/proxmox-api-go/commit/dc73194707f56582a8478d4b5a82cd4da220b8e2) API may take longer than 90s, extending to 300s (default in most Terraform plugins) ### 📊 Changes **3 files changed** (+13 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `proxmox/client.go` (+6 -1) 📝 `proxmox/config_qemu.go` (+2 -2) 📝 `proxmox/session.go` (+5 -0) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>