[PR #6] [MERGED] [WIP] Add support for multi device. #149

New issue

Closed

opened 2026-02-28 00:40:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 00:40:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Telmate/proxmox-api-go/pull/6
Author: @aabouzaid
Created: 7/15/2018
Status: ✅ Merged
Merged: 11/1/2018
Merged by: @ggongaware

Base: master ← Head: multi_device

📝 Commits (10+)

550c572 Added referrence to vmId to error message in GetVmInfo.
6707f9b Added referrence to vmName to error message in GetVmRefByName.
dbc5888 Merge pull request #5 from ivanpedersen/master
88e5f44 Added the possibility to read the macaddress from the proxmox configuration
251d9da support cloud-init for proxmox 5.2 and scsi0 storage
1d9eb7f fix clone command
ebe582e Merge branch 'master' into cloud-init
e0cf330 docs and sshkey format fix
75d3ffc make network param optional on clone/update, check for errors on WaitForCompletion
eccc46e need to escape equals also

📊 Changes

6 files changed (+580 additions, -116 deletions)

View changed files

📝 README.md (+21 -5)
📝 proxmox/client.go (+126 -11)
📝 proxmox/config_qemu.go (+318 -97)
📝 proxmox/session.go (+15 -3)
➕ proxmox/util.go (+62 -0)
➕ sizeunit/size_unit.go (+38 -0)

📄 Description

Thanks for your work, it's really helpful.
As you know, since it's still on going, there are many things are hard-coded in VM devices like network and hard disks.

So this PR is to make it more dynamic specially to define more than 1 net and hd device.
And all changes are taking backward comparability in mind.

The work still in progress, and I will let you know once I'm done.
But feel free to mention anything you see could be done better.
I came from Python background, and my golang knowledge is modest.

I also will open another PR for terraform-provider-proxmox.

Thanks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Telmate/proxmox-api-go/pull/6 **Author:** [@aabouzaid](https://github.com/aabouzaid) **Created:** 7/15/2018 **Status:** ✅ Merged **Merged:** 11/1/2018 **Merged by:** [@ggongaware](https://github.com/ggongaware) **Base:** `master` ← **Head:** `multi_device` --- ### 📝 Commits (10+) - [`550c572`](https://github.com/Telmate/proxmox-api-go/commit/550c572c3586c0509caf823365517c66d4c6d995) Added referrence to vmId to error message in GetVmInfo. - [`6707f9b`](https://github.com/Telmate/proxmox-api-go/commit/6707f9b4ea0ad65cb1c15011f187660320ceaa23) Added referrence to vmName to error message in GetVmRefByName. - [`dbc5888`](https://github.com/Telmate/proxmox-api-go/commit/dbc58882ea6946b889ece8ef54c0c1ad33058922) Merge pull request #5 from ivanpedersen/master - [`88e5f44`](https://github.com/Telmate/proxmox-api-go/commit/88e5f446834d87a1afac8c316f3e3a43083e344a) Added the possibility to read the macaddress from the proxmox configuration - [`251d9da`](https://github.com/Telmate/proxmox-api-go/commit/251d9dad67195f1f9b4f7358495fbcdc5ec5b1b5) support cloud-init for proxmox 5.2 and scsi0 storage - [`1d9eb7f`](https://github.com/Telmate/proxmox-api-go/commit/1d9eb7f6644da35432760ead4045933f32fb2a3d) fix clone command - [`ebe582e`](https://github.com/Telmate/proxmox-api-go/commit/ebe582e1589946a5b4212bbab34e21ef9cfeac2b) Merge branch 'master' into cloud-init - [`e0cf330`](https://github.com/Telmate/proxmox-api-go/commit/e0cf330f1f331869dcede510b7f6ae656a70027f) docs and sshkey format fix - [`75d3ffc`](https://github.com/Telmate/proxmox-api-go/commit/75d3ffc464cdf6b7552c4b118f3c5d86c822cd42) make network param optional on clone/update, check for errors on WaitForCompletion - [`eccc46e`](https://github.com/Telmate/proxmox-api-go/commit/eccc46e6e495f7059fc177899dba44a2d4cbe6f7) need to escape equals also ### 📊 Changes **6 files changed** (+580 additions, -116 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+21 -5) 📝 `proxmox/client.go` (+126 -11) 📝 `proxmox/config_qemu.go` (+318 -97) 📝 `proxmox/session.go` (+15 -3) ➕ `proxmox/util.go` (+62 -0) ➕ `sizeunit/size_unit.go` (+38 -0) </details> ### 📄 Description Thanks for your work, it's really helpful. As you know, since it's still on going, there are many things are hard-coded in VM devices like network and hard disks. So this PR is to make it more dynamic specially to define more than 1 net and hd device. And all changes are taking backward comparability in mind. The work still in progress, and I will let you know once I'm done. But feel free to mention anything you see could be done better. I came from Python background, and my golang knowledge is modest. I also will open [another PR](https://github.com/Telmate/terraform-provider-proxmox/pull/13) for terraform-provider-proxmox. Thanks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>