mirror of
https://github.com/Telmate/proxmox-api-go.git
synced 2026-04-25 23:45:55 +03:00
[GH-ISSUE #79] Support for latest Proxmox API #14
Labels
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/proxmox-api-go#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @romantomjak on GitHub (Jul 1, 2020).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/79
Hey, I'd like to help to add the vast majority of options available through the Proxmox API. I do have some concerns about client compatibility as I am certain not all options are supported by all versions of Proxmox's API, but unfortunately I have no experience building clients that support multiple versions of APIs.
Couple of questions to get the ball rolling:
Thanks!
@romantomjak commented on GitHub (Jul 6, 2020):
Hey @V-Paranoiaque, @carlpett and @aabouzaid from the looks of it you are the top contributors of this repository. Thought I'll ping you guys to get the ball rolling.
@aabouzaid commented on GitHub (Jul 6, 2020):
Hi @romantomjak I don't use Proxmox anymore and unfortunately cannot help with that.
I hope you all the best, it looks a very useful contribution 🚀
@romantomjak commented on GitHub (Jul 9, 2020):
Thank you @aabouzaid. Hopefully I'll hear some good news from others :)
@carlpett commented on GitHub (Jul 11, 2020):
Hey @romantomjak,
I'm not actually a maintainer on the repo, I just submitted some patches that I needed. I think you want @ggongaware :)
But while I'm here, some thoughts on your general questions:
@romantomjak commented on GitHub (Jul 15, 2020):
Thank you @carlpett, that actually makes a lot of sense! I think the last point ties in nicely with test coverage as well which I think is a must!
So maybe I could first start with adding some test coverage and making things more robust along the way?
@carlpett commented on GitHub (Jul 18, 2020):
Sounds like a reasonable start!
Although it'll require some setup work, I'd personally suggest aiming for more integration-style tests over than unit tests that mock out Proxmox. Maybe a Vagrant box per Proxmox version, or something similar. The tests will defintely take longer to run, but the confidence will be much higher.
@romantomjak commented on GitHub (Jul 20, 2020):
That is a brilliant idea! I'll look into how to setup a proxmox vagrant box as I'm not entirely sure how proxmox virtualization will work inside a VM. Thanks for being so responsive @carlpett ❤️