starred/proxmox-api-go
1
0
Fork 0
mirror of https://github.com/Telmate/proxmox-api-go.git synced 2026-04-25 23:45:55 +03:00
Code Issues 62 Projects Releases Packages Wiki Activity

[GH-ISSUE #443] Unreturned errors #114

New issue
Closed
opened 2026-02-28 00:40:37 +03:00 by kerem · 2 comments
kerem commented 2026-02-28 00:40:37 +03:00
Owner
Copy link

Originally created by @jaitaiwan on GitHub (Jul 25, 2025).
Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/443

Hi Folks,

Looking through some of the files I see places like https://github.com/Telmate/proxmox-api-go/blob/master/proxmox/client.go#L291 where errors are not logged and also not returned.

Is there a reason for that? If so would it be wise to document within the functions why we don't return?

Originally created by @jaitaiwan on GitHub (Jul 25, 2025). Original GitHub issue: https://github.com/Telmate/proxmox-api-go/issues/443 Hi Folks, Looking through some of the files I see places like https://github.com/Telmate/proxmox-api-go/blob/master/proxmox/client.go#L291 where errors are not logged and also not returned. Is there a reason for that? If so would it be wise to document within the functions why we don't return?
kerem closed this issue 2026-02-28 00:40:38 +03:00
kerem commented 2026-02-28 00:40:38 +03:00
Author
Owner
Copy link

@Tinyblargon commented on GitHub (Jul 25, 2025):

@jaitaiwan They are implicitly returned. When there are no variables in a return call, the output variables will be used.

<!-- gh-comment-id:3116657015 --> @Tinyblargon commented on GitHub (Jul 25, 2025): @jaitaiwan They are implicitly returned. When there are no variables in a `return` call, the output variables will be used.
kerem commented 2026-02-28 00:40:38 +03:00
Author
Owner
Copy link

@jaitaiwan commented on GitHub (Jul 25, 2025):

Oh I'm so sorry I completely missed the named return types.

<!-- gh-comment-id:3116677593 --> @jaitaiwan commented on GitHub (Jul 25, 2025): Oh I'm so sorry I completely missed the named return types.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/go_modules/golang.org/x/crypto-0.45.0
issue-300-fix
go-119-upgrade
logic-improvements
getUserPermissions
cicustom
next_if_conflict
cloud-init
add_full_clone_option
No results found.
Labels
Clear labels   
good first issue

   
issue/confirmed

   
issue/critical

   
proposal/accepted

   
pull-request

Mirrored from GitHub Pull Request

  
type/bug

   
type/enhancement

   
type/feature

   
type/question

   
type/refactoring

   
type/testing

   
type/testing
No labels
good first issue
issue/confirmed
issue/critical
proposal/accepted
pull-request
type/bug
type/enhancement
type/feature
type/question
type/refactoring
type/testing
type/testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/proxmox-api-go#114
No description provided.