starred/proxcenter-ui

Fork 0

mirror of https://github.com/adminsyspro/proxcenter-ui.git synced 2026-04-25 14:35:56 +03:00

[GH-ISSUE #7] Language change does not apply to all areas of the UI - some remain in French when set to English #118

New issue

Closed

opened 2026-03-13 17:12:14 +03:00 by kerem · 9 comments

kerem commented

2026-03-13 17:12:14 +03:00

Owner

Originally created by @turnipy on GitHub (Feb 18, 2026).
Original GitHub issue: https://github.com/adminsyspro/proxcenter-ui/issues/7

When set to English, multiple areas still appear in French.

For example, when I open available updates, then click upgrade, the next window is all in French instead of English. I have seen one or more other locations but sorry I didnt record where.

Originally created by @turnipy on GitHub (Feb 18, 2026). Original GitHub issue: https://github.com/adminsyspro/proxcenter-ui/issues/7 When set to English, multiple areas still appear in French. For example, when I open available updates, then click upgrade, the next window is all in French instead of English. I have seen one or more other locations but sorry I didnt record where.

kerem closed this issue

2026-03-13 17:12:19 +03:00

kerem commented

2026-03-13 17:12:24 +03:00

Author

Owner

@DanaramaPyjama commented on GitHub (Feb 18, 2026):

+1 for this

@DanaramaPyjama commented on GitHub (Feb 18, 2026): +1 for this

kerem commented

2026-03-13 17:12:29 +03:00

Author

Owner

@adminsyspro commented on GitHub (Feb 18, 2026):

Thanks for reporting this. We've pushed a fix in commit 604b00c that addresses the majority of hardcoded French strings in the UI.

What was fixed:

All hardcoded fr-FR date formatting replaced with locale-aware formatting across 11 component files
~290 hardcoded French strings replaced with proper i18n translations across ~35 files (error pages, update dialogs, rolling update wizard, jobs page, RBAC/users/audit pages, firewall rule panels, email template editor, console, dashboard widgets, etc.)
~80 new translation keys added to both en.json and fr.json

Remaining (lower priority):

API route error/success messages (e.g. "Non autorise", "Erreur serveur") that appear in toast notifications -- these are server-side and will be addressed in a follow-up
Date formatting in API routes (server-side)

After updating, switching to English should now show a fully English UI. Please let us know if you still spot any French strings when set to English.

@adminsyspro commented on GitHub (Feb 18, 2026): Thanks for reporting this. We've pushed a fix in commit 604b00c that addresses the majority of hardcoded French strings in the UI. **What was fixed:** - All hardcoded `fr-FR` date formatting replaced with locale-aware formatting across 11 component files - ~290 hardcoded French strings replaced with proper i18n translations across ~35 files (error pages, update dialogs, rolling update wizard, jobs page, RBAC/users/audit pages, firewall rule panels, email template editor, console, dashboard widgets, etc.) - ~80 new translation keys added to both en.json and fr.json **Remaining (lower priority):** - API route error/success messages (e.g. "Non autorise", "Erreur serveur") that appear in toast notifications -- these are server-side and will be addressed in a follow-up - Date formatting in API routes (server-side) After updating, switching to English should now show a fully English UI. Please let us know if you still spot any French strings when set to English.

kerem commented

2026-03-13 17:12:35 +03:00

Author

Owner

@turnipy commented on GitHub (Feb 18, 2026):

Much better thank you. Note that when I updated to test this fix, my proxmox cluster and PBS connections were failing until I reapplied the API token and secret to both, then it worked again

@turnipy commented on GitHub (Feb 18, 2026): Much better thank you. Note that when I updated to test this fix, my proxmox cluster and PBS connections were failing until I reapplied the API token and secret to both, then it worked again

kerem commented

2026-03-13 17:12:40 +03:00

Author

Owner

@StopTheNewWorldOrder commented on GitHub (Feb 19, 2026):

@adminsyspro I updated and just noticed in frontend/public/novnc/console.html there is still some hard-coded French that shows up in the console UI's toolbar on the 3 leftmost icons for vm-actions hover

... and in the text labels of the 2 buttons on the right.

@StopTheNewWorldOrder commented on GitHub (Feb 19, 2026): @adminsyspro I updated and just noticed in [frontend/public/novnc/console.html](https://github.com/adminsyspro/proxcenter-ui/blob/main/frontend/public/novnc/console.html) there is still some hard-coded French that shows up in the console UI's toolbar on the 3 leftmost icons for vm-actions hover <img width="173" height="80" alt="Image" src="https://github.com/user-attachments/assets/f6567f2a-220b-4fd4-a825-ab4b0957ca01" /> ... and in the text labels of the 2 buttons on the right. <img width="236" height="44" alt="Image" src="https://github.com/user-attachments/assets/d32e7711-5e91-4162-a614-85b32a3c568b" />

kerem commented

2026-03-13 17:12:45 +03:00

Author

Owner

@adminsyspro commented on GitHub (Feb 19, 2026):

Good catch! Fixed in cb1b7d3 — all hardcoded French text in the VNC console has been translated to English. Thanks for reporting!

@adminsyspro commented on GitHub (Feb 19, 2026): Good catch! Fixed in [cb1b7d3](https://github.com/adminsyspro/proxcenter-ui/commit/cb1b7d3) — all hardcoded French text in the VNC console has been translated to English. Thanks for reporting!

kerem commented

2026-03-13 17:12:50 +03:00

Author

Owner

@StopTheNewWorldOrder commented on GitHub (Feb 19, 2026):

Glad I could help and thank you @adminsyspro, great project!

@StopTheNewWorldOrder commented on GitHub (Feb 19, 2026): Glad I could help and thank you @adminsyspro, great project!

kerem commented

2026-03-13 17:12:55 +03:00

Author

Owner

@adminsyspro commented on GitHub (Feb 19, 2026):

If you have any suggestions or features requests, doesn't hesitate to post here : https://github.com/adminsyspro/proxcenter-ui/discussions

Regards.

@adminsyspro commented on GitHub (Feb 19, 2026): If you have any suggestions or features requests, doesn't hesitate to post here : https://github.com/adminsyspro/proxcenter-ui/discussions Regards.

kerem commented

2026-03-13 17:13:00 +03:00

Author

Owner

@DwayneGoddem commented on GitHub (Feb 19, 2026):

When you try to add a host and it fail's you get this text in a RED banner at the top on the pop window
"Non authentifié"

@DwayneGoddem commented on GitHub (Feb 19, 2026): When you try to add a host and it fail's you get this text in a RED banner at the top on the pop window "Non authentifié"

kerem commented

2026-03-13 17:13:05 +03:00

Author

Owner

@adminsyspro commented on GitHub (Feb 20, 2026):

All hardcoded French/English strings across the UI have been internationalized or translated. Here's what was done:

3 commits covering 30+ files, ~800 translation keys added:

Pages & components fixed:

Inventory: CreateVmDialog, CreateLxcDialog, InventoryDetails, InventoryTree, RootInventoryView, VCenterSummary, VmDetailTabs, NodeTabs, ClusterTabs, BackupJobsPanel
Network/Firewall: Dashboard, Objects, ClusterRules, HostRules, FirewallPolicy, RuleFormDialog, network page
Security: Audit logs, Users, RBAC
Operations: Alerts, Backups, Task Center
Storage: Ceph
Automation: DRS
Settings: Settings page, EmailTemplateEditor
Resources: All resource monitoring components
Dashboard: ZeroTrustCoverageWidget

Approach:

All user-facing strings now use next-intl t() translation calls
~800 new keys added to both en.json and fr.json
EmailTemplateEditor (email template macros/defaults) converted to English (no i18n needed)
PDF export intentionally left in English for now

Switching language now applies consistently across the entire UI.

@adminsyspro commented on GitHub (Feb 20, 2026): All hardcoded French/English strings across the UI have been internationalized or translated. Here's what was done: **3 commits covering 30+ files, ~800 translation keys added:** ### Pages & components fixed: - **Inventory**: CreateVmDialog, CreateLxcDialog, InventoryDetails, InventoryTree, RootInventoryView, VCenterSummary, VmDetailTabs, NodeTabs, ClusterTabs, BackupJobsPanel - **Network/Firewall**: Dashboard, Objects, ClusterRules, HostRules, FirewallPolicy, RuleFormDialog, network page - **Security**: Audit logs, Users, RBAC - **Operations**: Alerts, Backups, Task Center - **Storage**: Ceph - **Automation**: DRS - **Settings**: Settings page, EmailTemplateEditor - **Resources**: All resource monitoring components - **Dashboard**: ZeroTrustCoverageWidget ### Approach: - All user-facing strings now use `next-intl` `t()` translation calls - ~800 new keys added to both `en.json` and `fr.json` - EmailTemplateEditor (email template macros/defaults) converted to English (no i18n needed) - PDF export intentionally left in English for now Switching language now applies consistently across the entire UI.