[PR #59] [MERGED] fix(a11y): set <html lang="en"> — was incorrectly set to "de" #98

New issue

Closed

opened 2026-03-02 15:47:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:47:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PegaProx/project-pegaprox/pull/59
Author: @ry-ops
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @mkellermann97

Base: main ← Head: fix/html-lang-attribute

📝 Commits (1)

ff57eea fix(a11y): set <html lang="en"> — was incorrectly set to "de"

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 web/index.html (+1 -1)

📄 Description

Summary

The document lang attribute was hardcoded as German (lang="de") even though the app defaults to English and all static markup is in English.

Screen readers, browser translation prompts, and search engine crawlers all use the lang attribute to determine the page language. With lang="de" set, German-speaking users would get no browser translation offer (since the browser thinks it's already in their language), and English screen readers would use incorrect pronunciation rules.

The runtime language selection is already handled by LanguageContext / localStorage — this attribute only needs to reflect the document's default language.

Test plan

Load the page and inspect the <html> element — should show lang="en"
Verify browser translation offer appears for non-English browser users
Verify runtime language switching (EN/DE) still works as before

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PegaProx/project-pegaprox/pull/59 **Author:** [@ry-ops](https://github.com/ry-ops) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@mkellermann97](https://github.com/mkellermann97) **Base:** `main` ← **Head:** `fix/html-lang-attribute` --- ### 📝 Commits (1) - [`ff57eea`](https://github.com/PegaProx/project-pegaprox/commit/ff57eeac761c75ca3216a3f23ca6d50b1ef3c884) fix(a11y): set <html lang="en"> — was incorrectly set to "de" ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/index.html` (+1 -1) </details> ### 📄 Description ## Summary The document `lang` attribute was hardcoded as German (`lang="de"`) even though the app defaults to English and all static markup is in English. Screen readers, browser translation prompts, and search engine crawlers all use the `lang` attribute to determine the page language. With `lang="de"` set, German-speaking users would get no browser translation offer (since the browser thinks it's already in their language), and English screen readers would use incorrect pronunciation rules. The runtime language selection is already handled by `LanguageContext` / `localStorage` — this attribute only needs to reflect the document's default language. ## Test plan - [ ] Load the page and inspect the `<html>` element — should show `lang="en"` - [ ] Verify browser translation offer appears for non-English browser users - [ ] Verify runtime language switching (EN/DE) still works as before 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>