[PR #58] [MERGED] fix(disk-move): add 'delete source' checkbox to Move Disk dialog #96

New issue

Closed

opened 2026-03-02 15:47:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:47:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PegaProx/project-pegaprox/pull/58
Author: @ry-ops
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/25/2026
Merged by: @MrMasterbay

Base: main ← Head: fix/disk-move-delete-source

📝 Commits (1)

04dd9b6 fix(disk-move): add 'delete source' checkbox to Move Disk dialog

📊 Changes

1 file changed (+5 additions, -5 deletions)

View changed files

📝 web/index.html (+5 -5)

📄 Description

Summary

Fixes #52

The Move Disk modal gave users no control over whether the source volume was deleted after the move — it always used the backend default (delete=true). Users who wanted to keep the original had to go into the PVE UI or SSH to handle it manually.

Add deleteSource boolean state (defaults to true) and a checkbox in MoveDiskModal
Propagate the flag through handleMoveDisk → delete: in the JSON body (the existing /disks/:id/move route already accepts this field)
Fix hardcoded German strings in the modal ("Festplatte verschieben", "von") — replaced with t('moveDisk') and t('from')
Add EN/DE i18n keys: moveDisk, deleteSourceDisk

Test plan

Open disk move dialog on a running or stopped VM
Verify "Delete source disk after move" checkbox appears, checked by default
Uncheck it, start a move — confirm source volume is retained as unused0 in PVE
Check it, start a move — confirm source volume is deleted after move completes
Verify EN and DE labels render correctly

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PegaProx/project-pegaprox/pull/58 **Author:** [@ry-ops](https://github.com/ry-ops) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/25/2026 **Merged by:** [@MrMasterbay](https://github.com/MrMasterbay) **Base:** `main` ← **Head:** `fix/disk-move-delete-source` --- ### 📝 Commits (1) - [`04dd9b6`](https://github.com/PegaProx/project-pegaprox/commit/04dd9b6dbfc362004120a653dea894ff4c3d811c) fix(disk-move): add 'delete source' checkbox to Move Disk dialog ### 📊 Changes **1 file changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `web/index.html` (+5 -5) </details> ### 📄 Description ## Summary Fixes #52 The Move Disk modal gave users no control over whether the source volume was deleted after the move — it always used the backend default (delete=true). Users who wanted to keep the original had to go into the PVE UI or SSH to handle it manually. - Add `deleteSource` boolean state (defaults to `true`) and a checkbox in `MoveDiskModal` - Propagate the flag through `handleMoveDisk` → `delete:` in the JSON body (the existing `/disks/:id/move` route already accepts this field) - Fix hardcoded German strings in the modal ("Festplatte verschieben", "von") — replaced with `t('moveDisk')` and `t('from')` - Add EN/DE i18n keys: `moveDisk`, `deleteSourceDisk` ## Test plan - [ ] Open disk move dialog on a running or stopped VM - [ ] Verify "Delete source disk after move" checkbox appears, checked by default - [ ] Uncheck it, start a move — confirm source volume is retained as `unused0` in PVE - [ ] Check it, start a move — confirm source volume is deleted after move completes - [ ] Verify EN and DE labels render correctly 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>