[PR #56] [MERGED] fix(console): include cluster host in consoleInfo for external PVE link #93

New issue

Closed

opened 2026-03-02 15:47:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:47:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PegaProx/project-pegaprox/pull/56
Author: @ry-ops
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @mkellermann97

Base: main ← Head: fix/vnc-console-undefined-hostname

📝 Commits (1)

1c4faa2 fix(console): include cluster host in consoleInfo for external PVE link

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 web/index.html (+1 -1)

📄 Description

Summary

Fixes #53

openInProxmox() builds the external PVE console URL as:

https://${consoleInfo.host}:8006/?console=...

But handleOpenConsole was setting consoleInfo without a host field:

// before
setConsoleInfo({vmid: resource.vmid, node: resource.node, type: resource.type});

This caused consoleInfo.host to be undefined, producing a broken URL:

https://undefined:8006/?console=qemu&novnc=1&vmid=100&node=pve

Fix: Pass the current cluster's host into consoleInfo when opening the console modal:

// after
setConsoleInfo({vmid: resource.vmid, node: resource.node, type: resource.type, host: selectedCluster?.host});

Test plan

Open a VM console modal
Click the "External" button — URL should resolve to https://<cluster-host>:8006/?console=...
Verify no undefined appears in the generated URL

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PegaProx/project-pegaprox/pull/56 **Author:** [@ry-ops](https://github.com/ry-ops) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@mkellermann97](https://github.com/mkellermann97) **Base:** `main` ← **Head:** `fix/vnc-console-undefined-hostname` --- ### 📝 Commits (1) - [`1c4faa2`](https://github.com/PegaProx/project-pegaprox/commit/1c4faa2ea4c0b7da3bf4f190d9d8ffc95afa64b4) fix(console): include cluster host in consoleInfo for external PVE link ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/index.html` (+1 -1) </details> ### 📄 Description ## Summary Fixes #53 `openInProxmox()` builds the external PVE console URL as: ``` https://${consoleInfo.host}:8006/?console=... ``` But `handleOpenConsole` was setting `consoleInfo` without a `host` field: ```js // before setConsoleInfo({vmid: resource.vmid, node: resource.node, type: resource.type}); ``` This caused `consoleInfo.host` to be `undefined`, producing a broken URL: ``` https://undefined:8006/?console=qemu&novnc=1&vmid=100&node=pve ``` **Fix:** Pass the current cluster's host into `consoleInfo` when opening the console modal: ```js // after setConsoleInfo({vmid: resource.vmid, node: resource.node, type: resource.type, host: selectedCluster?.host}); ``` ## Test plan - [ ] Open a VM console modal - [ ] Click the "External" button — URL should resolve to `https://<cluster-host>:8006/?console=...` - [ ] Verify no `undefined` appears in the generated URL 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>