[PR #55] [MERGED] fix(deploy): skip interactive port prompt when stdin is not a terminal #92

New issue

Closed

opened 2026-03-02 15:47:53 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:47:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PegaProx/project-pegaprox/pull/55
Author: @ry-ops
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/21/2026
Merged by: @mkellermann97

Base: main ← Head: fix/install-script-stdin-pipe

📝 Commits (1)

7dcb6a5 fix(deploy): skip interactive port prompt when stdin is not a terminal

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 deploy.sh (+2 -1)

📄 Description

Summary

Fixes #54

When running the one-liner install via curl -sSL ... | sudo bash, stdin is a pipe rather than a terminal. The read call at Step 6/6 waits for input that never arrives, and with set -e in effect the script exits silently — leaving the install incomplete.

Add && [ -t 0 ] to the INTERACTIVE check so the port-selection prompt is only shown when a real TTY is attached
Non-interactive / piped installs fall through cleanly and use the default ACCESS_PORT (5000)

This is exactly the fix confirmed by the original reporter in the issue.

Test plan

Run curl -sSL <install-url> | sudo bash — install should complete through Step 6/6 without hanging
Run sudo ./deploy.sh directly in a terminal — interactive port prompt should still appear
Run sudo ./deploy.sh --no-interactive — should skip prompt as before

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PegaProx/project-pegaprox/pull/55 **Author:** [@ry-ops](https://github.com/ry-ops) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/21/2026 **Merged by:** [@mkellermann97](https://github.com/mkellermann97) **Base:** `main` ← **Head:** `fix/install-script-stdin-pipe` --- ### 📝 Commits (1) - [`7dcb6a5`](https://github.com/PegaProx/project-pegaprox/commit/7dcb6a5e9d8bc9e27ea61bff821d35d93f4884cd) fix(deploy): skip interactive port prompt when stdin is not a terminal ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `deploy.sh` (+2 -1) </details> ### 📄 Description ## Summary Fixes #54 When running the one-liner install via `curl -sSL ... | sudo bash`, stdin is a pipe rather than a terminal. The `read` call at Step 6/6 waits for input that never arrives, and with `set -e` in effect the script exits silently — leaving the install incomplete. - Add `&& [ -t 0 ]` to the `INTERACTIVE` check so the port-selection prompt is only shown when a real TTY is attached - Non-interactive / piped installs fall through cleanly and use the default `ACCESS_PORT` (5000) This is exactly the fix confirmed by the original reporter in the issue. ## Test plan - [ ] Run `curl -sSL <install-url> | sudo bash` — install should complete through Step 6/6 without hanging - [ ] Run `sudo ./deploy.sh` directly in a terminal — interactive port prompt should still appear - [ ] Run `sudo ./deploy.sh --no-interactive` — should skip prompt as before 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>