[PR #63] [MERGED] fix(search): navigate to resources tab when jumping to a VM from search #101

New issue

Closed

opened 2026-03-02 15:47:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 15:47:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/PegaProx/project-pegaprox/pull/63
Author: @ry-ops
Created: 2/21/2026
Status: ✅ Merged
Merged: 2/22/2026
Merged by: @mkellermann97

Base: main ← Head: fix/vm-search-navigation

📝 Commits (1)

be93cea fix(search): navigate to resources tab when jumping to a VM from search

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 web/index.html (+2 -1)

📄 Description

Summary

Fixes #49 (VM search navigation goes to cluster overview instead of the VM)

When a user selected a VM from the global search results, navigateToResult called setSelectedCluster — which lands on the cluster overview tab — and then 300 ms later set highlightedVm. Because the active tab was still 'overview', the VM list was never visible and the highlight had no effect.

Fix: Call setActiveTab('resources') before the highlight timeout so the resources/VM list is shown when the highlight fires.

Test plan

Use the global search bar to find a VM by name
Click or press Enter on a search result — should land on the Resources tab with the VM highlighted
Verify the highlight fades after ~3 seconds
Verify navigating to a non-VM search result (e.g. a node) still lands on the overview tab

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/PegaProx/project-pegaprox/pull/63 **Author:** [@ry-ops](https://github.com/ry-ops) **Created:** 2/21/2026 **Status:** ✅ Merged **Merged:** 2/22/2026 **Merged by:** [@mkellermann97](https://github.com/mkellermann97) **Base:** `main` ← **Head:** `fix/vm-search-navigation` --- ### 📝 Commits (1) - [`be93cea`](https://github.com/PegaProx/project-pegaprox/commit/be93cea8077d3fb489b9b41a32b23a830280a7e3) fix(search): navigate to resources tab when jumping to a VM from search ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `web/index.html` (+2 -1) </details> ### 📄 Description ## Summary Fixes #49 (VM search navigation goes to cluster overview instead of the VM) When a user selected a VM from the global search results, `navigateToResult` called `setSelectedCluster` — which lands on the cluster **overview** tab — and then 300 ms later set `highlightedVm`. Because the active tab was still `'overview'`, the VM list was never visible and the highlight had no effect. **Fix:** Call `setActiveTab('resources')` before the highlight timeout so the resources/VM list is shown when the highlight fires. ## Test plan - [ ] Use the global search bar to find a VM by name - [ ] Click or press Enter on a search result — should land on the **Resources** tab with the VM highlighted - [ ] Verify the highlight fades after ~3 seconds - [ ] Verify navigating to a non-VM search result (e.g. a node) still lands on the overview tab 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>