starred/ppsspp

Fork 0

mirror of https://github.com/hrydgard/ppsspp.git synced 2026-04-25 14:16:10 +03:00

[GH-ISSUE #2548] Opening video title screens for Legend of Heroes: Trails in The Sky and Ys Seven now broken since v0.8.1-88-gcff69a3 #997

New issue

Closed

opened 2026-03-17 18:34:34 +03:00 by kerem · 8 comments

kerem commented

2026-03-17 18:34:34 +03:00

Owner

Originally created by @solarmystic on GitHub (Jun 30, 2013).
Original GitHub issue: https://github.com/hrydgard/ppsspp/issues/2548

Issue is as described in the title. Last working revision for working intro cutscenes for both those games is v0.8.1-76-g95d6260.

Normally I'd describe the ability to skip those screens as a bonus, but this is still broken behaviour since other videos in the games themselves may also be broken.

Problem reproduction:-

Download v0.8.1-88-gcff69a3 (or later) from the Orphis buildbot
Start up either game
Game skips straight to the Main Menu without going through the usual XSEED and Falcom title screens. (which are short videos)

The suspected revision/commit that is responsible for the issue is either v0.8.1-84-g9628001 github.com/hrydgard/ppsspp@9628001f56 or v0.8.1-82-gd18eb99 github.com/hrydgard/ppsspp@d18eb994da since they both deal with videos and v0.8.1-76-g95d6260 is the last working one for both those games.

Logfiles taken from Legend of Heroes: Trails in the Sky (game start to main menu then exit, without skipping any videos in between):

(from 0.8.1-76, last downloadable working build):-
https://gist.github.com/solarmystic/5894315

(from 0.8.1-88, first downloadable broken build):-
https://gist.github.com/solarmystic/5894320

Youtube videos showing the difference:-

0.8.1-76 (working behaviour)
http://www.youtube.com/watch?v=_eo6JiTMxhY

0.8.1-88 (broken behaviour)
http://www.youtube.com/watch?v=OnpE3HAfVhg

Originally created by @solarmystic on GitHub (Jun 30, 2013). Original GitHub issue: https://github.com/hrydgard/ppsspp/issues/2548 Issue is as described in the title. Last working revision for working intro cutscenes for both those games is v0.8.1-76-g95d6260. Normally I'd describe the ability to skip those screens as a bonus, but this is still broken behaviour since other videos in the games themselves may also be broken. Problem reproduction:- 1. Download v0.8.1-88-gcff69a3 (or later) from the Orphis buildbot 2. Start up either game 3. Game skips straight to the Main Menu without going through the usual XSEED and Falcom title screens. (which are short videos) The suspected revision/commit that is responsible for the issue is either v0.8.1-84-g9628001 https://github.com/hrydgard/ppsspp/commit/9628001f5601dd362c6588aea8b414f57a6a90e4 or v0.8.1-82-gd18eb99 https://github.com/hrydgard/ppsspp/commit/d18eb994daf8b958553545f0aa89e965c0474f9b since they both deal with videos and v0.8.1-76-g95d6260 is the last working one for both those games. ![capture](https://f.cloud.github.com/assets/4345150/727040/d2c884dc-e15b-11e2-9f7d-c5d77892e2ac.jpg) Logfiles taken from Legend of Heroes: Trails in the Sky (game start to main menu then exit, without skipping any videos in between): (from 0.8.1-76, last downloadable working build):- https://gist.github.com/solarmystic/5894315 (from 0.8.1-88, first downloadable broken build):- https://gist.github.com/solarmystic/5894320 Youtube videos showing the difference:- 0.8.1-76 (working behaviour) http://www.youtube.com/watch?v=_eo6JiTMxhY 0.8.1-88 (broken behaviour) http://www.youtube.com/watch?v=OnpE3HAfVhg

kerem closed this issue

2026-03-17 18:34:40 +03:00

kerem commented

2026-03-17 18:34:45 +03:00

Author

Owner

@oioitff commented on GitHub (Jun 30, 2013):

Hmm, it should be broken by #2521.
@solarmystic Do those games call sceMpegAvcDecodeDetail before sceMpegGetAvcAu ?

@oioitff commented on GitHub (Jun 30, 2013): Hmm, it should be broken by #2521. @solarmystic Do those games call **sceMpegAvcDecodeDetail** before **sceMpegGetAvcAu** ?

kerem commented

2026-03-17 18:34:51 +03:00

Author

Owner

@solarmystic commented on GitHub (Jun 30, 2013):

@oioitff

I think so. How would I find that out?

@solarmystic commented on GitHub (Jun 30, 2013): @oioitff I think so. How would I find that out?

kerem commented

2026-03-17 18:34:56 +03:00

Author

Owner

@oioitff commented on GitHub (Jun 30, 2013):

You can simply add INFO_LOG(...) in these two functions in sceMpeg.cpp.

If so, you can try this simple fix in sceMpeg.cpp:

int sceMpegAvcDecodeDetail(u32 mpeg, u32 detailAddr)
{
    ...
-   Memory::Write_U32(ctx->avc.avcDecodeResult, detailAddr + 0);
+   Memory::Write_U32(ctx->avc.avcDecodeResult ? ctx->avc.avcDecodeResult : MPEG_AVC_DECODE_SUCCESS, detailAddr + 0);
    ...
}

@oioitff commented on GitHub (Jun 30, 2013): You can simply add INFO_LOG(...) in these two functions in sceMpeg.cpp. If so, you can try this simple fix in sceMpeg.cpp: ``` int sceMpegAvcDecodeDetail(u32 mpeg, u32 detailAddr) { ... - Memory::Write_U32(ctx->avc.avcDecodeResult, detailAddr + 0); + Memory::Write_U32(ctx->avc.avcDecodeResult ? ctx->avc.avcDecodeResult : MPEG_AVC_DECODE_SUCCESS, detailAddr + 0); ... } ```

kerem commented

2026-03-17 18:35:01 +03:00

Author

Owner

@solarmystic commented on GitHub (Jun 30, 2013):

@oioitff

I'm sorry, I'm not so sure how to do that, I'm rather noobish in programming. Could I have a test build from you with that fix instead and test it out to see whether it fixes it? I can do it right away.

@solarmystic commented on GitHub (Jun 30, 2013): @oioitff I'm sorry, I'm not so sure how to do that, I'm rather noobish in programming. Could I have a test build from you with that fix instead and test it out to see whether it fixes it? I can do it right away.

kerem commented

2026-03-17 18:35:06 +03:00

Author

Owner

@oioitff commented on GitHub (Jun 30, 2013):

Thanks. Here is a test build with that fix and some info logs: https://docs.google.com/file/d/0B1ftGc2t9-dZVTNFVDl4NXpNSVE/edit?usp=sharing

@oioitff commented on GitHub (Jun 30, 2013): Thanks. Here is a test build with that fix and some info logs: https://docs.google.com/file/d/0B1ftGc2t9-dZVTNFVDl4NXpNSVE/edit?usp=sharing

kerem commented

2026-03-17 18:35:11 +03:00

Author

Owner

@solarmystic commented on GitHub (Jun 30, 2013):

@oioitff
Using the test build, the issue is still not fixed unfortunately

Here is the logfile using your testbuild (when running Legend of Heroes: Trails in The Sky+infologs):-

https://gist.github.com/solarmystic/5894807

Logfile when running Ys Seven using your testbuild(+infologs):-

https://gist.github.com/solarmystic/5894810

@solarmystic commented on GitHub (Jun 30, 2013): @oioitff Using the test build, the issue is still not fixed unfortunately Here is the logfile using your testbuild (when running Legend of Heroes: Trails in The Sky+infologs):- https://gist.github.com/solarmystic/5894807 Logfile when running Ys Seven using your testbuild(+infologs):- https://gist.github.com/solarmystic/5894810

kerem commented

2026-03-17 18:35:16 +03:00

Author

Owner

@oioitff commented on GitHub (Jun 30, 2013):

@solarmystic That's enough, thanks :)

@oioitff commented on GitHub (Jun 30, 2013): @solarmystic That's enough, thanks :)

kerem commented

2026-03-17 18:35:21 +03:00

Author

Owner

@solarmystic commented on GitHub (Jun 30, 2013):

Yep it's fixed now, thanks @oioitff .

@solarmystic commented on GitHub (Jun 30, 2013): Yep it's fixed now, thanks @oioitff .

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ppsspp#997

No description provided.

Rows
Columns