mirror of
https://github.com/hrydgard/ppsspp.git
synced 2026-04-24 21:56:10 +03:00
[GH-ISSUE #4405] PPSSPP: Linear Texture Filtering broken in Tekken 6 since v0.9.1-2045-ga3f2fcf #1798
Labels
No labels
Atrac3+
Audio
CPU emulation
D3D11
D3D9 (removed)
Depth / Z
Feature Request
Font Atlas
GE emulation
Guardband / Range Culling
HLE/Kernel
I/O
Input/Controller
MP3
Multithreading
Needs hardware testing
Networking/adhoc/infrastructure
No Feedback / Outdated?
OpenGL
PGF / sceFont
PSMF / MPEG
Platform-specific (Android)
Platform-specific (Windows)
Platform-specific (iOS)
PowerVR GPU
SDL2
Saving issue
User Interface
Vulkan
arm64jit
armjit
armv6
x86jit
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ppsspp#1798
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @solarmystic on GitHub (Nov 2, 2013).
Original GitHub issue: https://github.com/hrydgard/ppsspp/issues/4405
Issue is as stated above. Responsible commit is
github.com/hrydgard/ppsspp@4567acaf92by @DanyalZia merged into master with v0.9.1-2045-ga3f2fcfgithub.com/hrydgard/ppsspp@a3f2fcfd8fby @hrydgardSetting texture filtering to Linear or Linear on FMV doesn't work anymore for Tekken 6 since then, both ingame and during FMVs:
(click on the screenshots to observe the issue clearly)
FMV (pixellated even after Linear Filtering is forced in the graphics menu):

Ingame menu (letters remain pixellated even when Linear Filtering is forced in the Graphics menu):

Last working revision is v0.9.1-2043-g99d4ef1
github.com/hrydgard/ppsspp@99d4ef1e06FMV (smoothed out as expected):

Ingame menu (letters are smoothed out as expected with Linear Filtering)

I suspect other games may be affected by this commit too. Will add them into the issue report if and when I find them.
Tested on the following machine:
@solarmystic commented on GitHub (Nov 2, 2013):
Soul Calibur is also affected by this issue it seems.
(Observe the text in the red box)
Working as expected with v0.9.1-2043-g99d4ef1

github.com/hrydgard/ppsspp@99d4ef1e06(smoothed letters when Linear Filtering is selected)Broken in v0.9.1-2045-ga3f2fcf

github.com/hrydgard/ppsspp@a3f2fcfd8f(pixellated letters even with Linear Texture Filtering selected):@unknownbrackets commented on GitHub (Nov 2, 2013):
Why would the game use alpha testing for video? Well, it might be "enabled" but not really doing anything. I guess we could try harder to detect those cases.
Or just give up and let filtering break things at 2x.... which ain't great.
-[Unknown]
@hrydgard commented on GitHub (Nov 2, 2013):
That would probably be the same reason as always - alpha testing and color testing are free on the PSP so games sometimes just leave them on by accident, probably just forgetting to disable the state, as there's no harm anyway if you draw things that don't match the test criterion.
But yeah there are more checks we can do to rule out effects of these, and use the result of those checks for the linear filter enabling...
@Antonio1994 commented on GitHub (Nov 3, 2013):
It broke MGS PW too. Changing texture filter doesn't make any difference....
@hrydgard commented on GitHub (Nov 3, 2013):
Broke the filtering in MGS PW or broke the game? That's some ambiguous wording.
@Antonio1994 commented on GitHub (Nov 3, 2013):
Uh....sorry...I meant it broke the filtering....my mistake! :)
@unknownbrackets commented on GitHub (Dec 3, 2013):
How's the status of this? I recall there were related changes recently.
-[Unknown]
@solarmystic commented on GitHub (Dec 4, 2013):
The filtering works in FMVs now, but forcing Linear Filtering still does nothing for the pixelated ingame fonts. Same thing for Soul Calibur Broken Destiny.
@Antonio1994 commented on GitHub (Dec 9, 2013):
I dont know have you guys tryed it, but in MGS when I get in-game and exit fullscreen and enter fullscreen again the filtering works.....
@unknownbrackets commented on GitHub (May 13, 2014):
Does using something more like this help?
-[Unknown]
@solarmystic commented on GitHub (May 13, 2014):
@unknownbrackets Just adding those lines in? Or do I have to replace any prior lines with these ones?
In any case, appending those lines to the current master version of the file does not resolve the issue. Lnear Texture Filtering is still broken for the ingame fonts in Tekken 6.
@unknownbrackets commented on GitHub (May 13, 2014):
Replacing the if block that starts with
g_Config.iTexFiltering == LINEARwith those. But, these should apply separately anyway. That means we can't safely force linear filtering because it's inventing pixels that may have other alpha values than the game expects.Or we could make it ignore that and people will complain about the green outlines around characters or etc. in some games again.
-[Unknown]
@solarmystic commented on GitHub (May 16, 2014):
@unknownbrackets Unfortunately, https://github.com/hrydgard/ppsspp/issues/6088 doesn't resolve the issue in Tekken 6 for the pixelated fonts. Setting it to Linear still causes it to be pixelated.
Again, a reminder of what it used to look like with Linear Filtering set:-
Seems to be the only straggler though. Other games have functioning Linear Filtering now when forced in the options.. (like Crisis Core etc.)
@unknownbrackets commented on GitHub (May 16, 2014):
Well, I think that means it's using alpha test in a way that we can't know that we can safely ignore.
-[Unknown]
@ppmeis commented on GitHub (Jul 25, 2015):
Testing with latest build. Same status:

@unknownbrackets commented on GitHub (Feb 10, 2019):
So, thinking about this, I guess what we could do is use sampler objects (GL3.3+ / GLES3) to bind the texture in two slots, and then do BOTH nearest and linear.
That way, we could do color and alpha testing based on the nearest value, but still output the linear value. I think that's more or less staying true to the goals of higher render resolutions.
We could take this further, and when upscaling (not not texture replacements? not sure...), we could bind the original texture to the second slot. This would again allow for using nearest which would give us better chances of color tests and alpha tests working correctly.
-[Unknown]
@hrydgard commented on GitHub (Feb 10, 2019):
Yeah, that's definitely a possibility, although the mix between smooth filtering inside the solid regions coupled with the hard edges against the surroundings might look odd. Also, if the test is done against an ugly color it would still be able to bleed into the solid region.
@ghost commented on GitHub (Sep 14, 2021):
Auto Max Quality possible help this?