[PR #236] [MERGED] Working on test coverage #270

New issue

Closed

opened 2026-03-03 15:44:15 +03:00 by kerem · 0 comments

kerem commented 2026-03-03 15:44:15 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/236
Author: @nuryagdym
Created: 10/2/2024
Status: ✅ Merged
Merged: 10/2/2024
Merged by: @nuryagdym

Base: master ← Head: working-on-test-coverage

---

📝 Commits (3)

• d2bbf19 add more rules into .editorconfig
• c765b17 minor code refactor
• 9a3f831 tests - use assetsSame instead of assertEquals

📊 Changes

26 files changed (+261 additions, -318 deletions)

View changed files

📝 .editorconfig (+4 -0)
📝 src/DataMapper/RequestDataMapper/AkbankPosRequestDataMapper.php (+1 -1)
📝 src/DataMapper/RequestDataMapper/EstPosRequestDataMapper.php (+4 -1)
📝 src/DataMapper/RequestDataMapper/PayFlexCPV4PosRequestDataMapper.php (+0 -9)
📝 src/DataMapper/RequestDataMapper/ToslaPosRequestDataMapper.php (+1 -1)
📝 src/DataMapper/RequestDataMapper/VakifKatilimPosRequestDataMapper.php (+5 -5)
📝 src/Factory/RequestDataMapperFactory.php (+2 -5)
📝 tests/Unit/Crypt/EstPosCryptTest.php (+2 -2)
📝 tests/Unit/Crypt/EstV3PosCryptTest.php (+2 -2)
📝 tests/Unit/Crypt/GarantiPosCryptTest.php (+1 -1)
📝 tests/Unit/Crypt/PosNetV1PosCryptTest.php (+1 -1)
📝 tests/Unit/Crypt/ToslaPosCryptTest.php (+2 -2)
📝 tests/Unit/DataMapper/RequestDataMapper/EstPosRequestDataMapperTest.php (+67 -115)
📝 tests/Unit/DataMapper/RequestDataMapper/EstV3PosRequestDataMapperTest.php (+4 -4)
📝 tests/Unit/DataMapper/RequestDataMapper/GarantiPosRequestDataMapperTest.php (+1 -1)
📝 tests/Unit/DataMapper/RequestDataMapper/KuveytPosRequestDataMapperTest.php (+1 -1)
📝 tests/Unit/DataMapper/RequestDataMapper/PayFlexCPV4PosRequestDataMapperTest.php (+0 -12)
📝 tests/Unit/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapperTest.php (+5 -5)
📝 tests/Unit/DataMapper/RequestDataMapper/PayForPosRequestDataMapperTest.php (+124 -130)
📝 tests/Unit/DataMapper/RequestDataMapper/PosNetRequestDataMapperTest.php (+19 -6)

...and 6 more files

📄 Description

No description provided

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/236 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 10/2/2024 **Status:** ✅ Merged **Merged:** 10/2/2024 **Merged by:** [@nuryagdym](https://github.com/nuryagdym) **Base:** `master` ← **Head:** `working-on-test-coverage` --- ### 📝 Commits (3) - [`d2bbf19`](https://github.com/mewebstudio/pos/commit/d2bbf19f5bdbe9a047540f4d59151c37095d46d3) add more rules into .editorconfig - [`c765b17`](https://github.com/mewebstudio/pos/commit/c765b1774101fd84c611078f061263e056bfac97) minor code refactor - [`9a3f831`](https://github.com/mewebstudio/pos/commit/9a3f8317744456a97da7bc987d83cb3b26782a50) tests - use assetsSame instead of assertEquals ### 📊 Changes **26 files changed** (+261 additions, -318 deletions) <details> <summary>View changed files</summary> 📝 `.editorconfig` (+4 -0) 📝 `src/DataMapper/RequestDataMapper/AkbankPosRequestDataMapper.php` (+1 -1) 📝 `src/DataMapper/RequestDataMapper/EstPosRequestDataMapper.php` (+4 -1) 📝 `src/DataMapper/RequestDataMapper/PayFlexCPV4PosRequestDataMapper.php` (+0 -9) 📝 `src/DataMapper/RequestDataMapper/ToslaPosRequestDataMapper.php` (+1 -1) 📝 `src/DataMapper/RequestDataMapper/VakifKatilimPosRequestDataMapper.php` (+5 -5) 📝 `src/Factory/RequestDataMapperFactory.php` (+2 -5) 📝 `tests/Unit/Crypt/EstPosCryptTest.php` (+2 -2) 📝 `tests/Unit/Crypt/EstV3PosCryptTest.php` (+2 -2) 📝 `tests/Unit/Crypt/GarantiPosCryptTest.php` (+1 -1) 📝 `tests/Unit/Crypt/PosNetV1PosCryptTest.php` (+1 -1) 📝 `tests/Unit/Crypt/ToslaPosCryptTest.php` (+2 -2) 📝 `tests/Unit/DataMapper/RequestDataMapper/EstPosRequestDataMapperTest.php` (+67 -115) 📝 `tests/Unit/DataMapper/RequestDataMapper/EstV3PosRequestDataMapperTest.php` (+4 -4) 📝 `tests/Unit/DataMapper/RequestDataMapper/GarantiPosRequestDataMapperTest.php` (+1 -1) 📝 `tests/Unit/DataMapper/RequestDataMapper/KuveytPosRequestDataMapperTest.php` (+1 -1) 📝 `tests/Unit/DataMapper/RequestDataMapper/PayFlexCPV4PosRequestDataMapperTest.php` (+0 -12) 📝 `tests/Unit/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapperTest.php` (+5 -5) 📝 `tests/Unit/DataMapper/RequestDataMapper/PayForPosRequestDataMapperTest.php` (+124 -130) 📝 `tests/Unit/DataMapper/RequestDataMapper/PosNetRequestDataMapperTest.php` (+19 -6) _...and 6 more files_ </details> ### 📄 Description _No description provided_ --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-03-03 15:44:15 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

v2

v2-introduce-response-object

v1.8.0

issue-289-fix-kuveytpos-soap-calls

fix/phpstan-and-php8.5

v1.6

task/pacgage-upgrade

master-old-pkg

1.8.0

1.7.1

1.7.0

1.6.0

1.5.0

1.4.2

1.4.1

1.4.0

1.3.0

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.16.1

0.16.0

0.15.1

0.15.0

0.14.0

0.13.2

0.13.1

0.13.0

0.12.2

0.12.1

0.12.0

0.11.0

0.10.5

0.10.4

0.10.3

0.10.2

0.10.1

0.10.0

0.9.1

0.9.0

0.8.2

0.8.1

0.8.0

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.1

0.6.0

0.5.2

0.5.1

0.5.0

0.4.17

0.4.16

0.4.15

0.4.14

0.4.13

0.4.12

0.4.11

0.4.10

0.4.9

0.4.8

0.4.7

0.4.6

0.4.5

0.4.4

0.4.3

0.4.2

0.4.1

0.4.0

0.3.8

0.3.7

0.3.6

0.3.5

0.3.4

0.3.3

0.3.2

0.3.1

0.2.0

0.1.8

0.3.0

0.1.7

0.1.6

0.1.5

0.1.2

0.1.1

0.1.0

Labels

Clear labels   

PayFlexV4

  

TROY

  

akbankpos

  

bug

  

duplicate

  

enhancement

  

garanti

  

help wanted

  

isbank

  

kuveyt

  

payten

  

posnet

  

pull-request

Mirrored from GitHub Pull Request

  

vakifbank

  

ziraat

No labels

PayFlexV4

TROY

akbankpos

bug

duplicate

enhancement

garanti

help wanted

isbank

kuveyt

payten

posnet

pull-request

vakifbank

ziraat

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/pos#270

No description provided.