[PR #234] [MERGED] Working on test coverage #267

New issue

Closed

opened 2026-03-03 15:44:14 +03:00 by kerem · 0 comments

kerem commented 2026-03-03 15:44:14 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/234
Author: @nuryagdym
Created: 9/7/2024
Status: ✅ Merged
Merged: 9/24/2024
Merged by: @nuryagdym

Base: master ← Head: working-on-test-coverage

---

📝 Commits (10+)

• d34ef10 tests - cover event dispatch block
• 7864a8e tests - cover hashmismatchexception lines
• 0f51ef3 tests - cover getApiUrl method
• 926eb7e tests - cover get3DFormData
• 70fbfb2 tests - cover request data mapper recurring orders
• 9df0a70 tests - cover request data mapper not implemented methods
• 5011dd4 posnetv1 - fix undefined index when creating 3d host form data
• 2b18be7 tests - more coverage in request data mappers
• 6fc9271 updated .editorconfig
• 422b511 tests - cover not implemented methods

📊 Changes

42 files changed (+1640 additions, -301 deletions)

View changed files

📝 .editorconfig (+6 -0)
📝 composer.json (+3 -0)
📝 src/Crypt/PosNetV1PosCrypt.php (+6 -4)
📝 src/DataMapper/RequestDataMapper/PosNetV1PosRequestDataMapper.php (+2 -1)
📝 src/DataMapper/ResponseDataMapper/PosNetResponseDataMapper.php (+2 -2)
📝 src/DataMapper/ResponseDataMapper/PosNetV1PosResponseDataMapper.php (+2 -2)
📝 src/Gateways/AbstractGateway.php (+14 -7)
📝 src/Gateways/AkbankPos.php (+5 -2)
📝 src/Gateways/EstPos.php (+2 -1)
📝 src/Gateways/GarantiPos.php (+2 -1)
📝 src/Gateways/InterPos.php (+2 -1)
📝 src/Gateways/KuveytPos.php (+6 -3)
📝 src/Gateways/PayFlexCPV4Pos.php (+4 -2)
📝 src/Gateways/PayFlexV4Pos.php (+4 -2)
📝 src/Gateways/PayForPos.php (+3 -7)
📝 src/Gateways/PosNet.php (+6 -3)
📝 src/Gateways/PosNetV1Pos.php (+4 -2)
📝 src/Gateways/ToslaPos.php (+4 -2)
📝 src/Gateways/VakifKatilimPos.php (+6 -3)
📝 tests/Unit/DataMapper/RequestDataMapper/EstPosRequestDataMapperTest.php (+91 -27)

...and 22 more files

📄 Description

No description provided

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/234 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 9/7/2024 **Status:** ✅ Merged **Merged:** 9/24/2024 **Merged by:** [@nuryagdym](https://github.com/nuryagdym) **Base:** `master` ← **Head:** `working-on-test-coverage` --- ### 📝 Commits (10+) - [`d34ef10`](https://github.com/mewebstudio/pos/commit/d34ef10acf65d26d48f17f601f0d08d615abae66) tests - cover event dispatch block - [`7864a8e`](https://github.com/mewebstudio/pos/commit/7864a8ea7ce9f13db1d6595fe3d76154eb6fbc33) tests - cover hashmismatchexception lines - [`0f51ef3`](https://github.com/mewebstudio/pos/commit/0f51ef35c5da5a186f512f36af972439dd9f1088) tests - cover getApiUrl method - [`926eb7e`](https://github.com/mewebstudio/pos/commit/926eb7e2337338e4dd3b5caec654a7de3fb7bb97) tests - cover get3DFormData - [`70fbfb2`](https://github.com/mewebstudio/pos/commit/70fbfb286d6b3267c48946521e17d1b1033bf430) tests - cover request data mapper recurring orders - [`9df0a70`](https://github.com/mewebstudio/pos/commit/9df0a701de8a240826e451ce3780c98e6783c4d2) tests - cover request data mapper not implemented methods - [`5011dd4`](https://github.com/mewebstudio/pos/commit/5011dd4477d9497e3f5077b36e54a52b66c3e9fb) posnetv1 - fix undefined index when creating 3d host form data - [`2b18be7`](https://github.com/mewebstudio/pos/commit/2b18be760180d0f2df5b63695e0a93ae8ed3bf7f) tests - more coverage in request data mappers - [`6fc9271`](https://github.com/mewebstudio/pos/commit/6fc92714e49881cc4ee25563db78aa0576a30799) updated .editorconfig - [`422b511`](https://github.com/mewebstudio/pos/commit/422b511d05a8e6e36a4e96fe42722857c764a6c7) tests - cover not implemented methods ### 📊 Changes **42 files changed** (+1640 additions, -301 deletions) <details> <summary>View changed files</summary> 📝 `.editorconfig` (+6 -0) 📝 `composer.json` (+3 -0) 📝 `src/Crypt/PosNetV1PosCrypt.php` (+6 -4) 📝 `src/DataMapper/RequestDataMapper/PosNetV1PosRequestDataMapper.php` (+2 -1) 📝 `src/DataMapper/ResponseDataMapper/PosNetResponseDataMapper.php` (+2 -2) 📝 `src/DataMapper/ResponseDataMapper/PosNetV1PosResponseDataMapper.php` (+2 -2) 📝 `src/Gateways/AbstractGateway.php` (+14 -7) 📝 `src/Gateways/AkbankPos.php` (+5 -2) 📝 `src/Gateways/EstPos.php` (+2 -1) 📝 `src/Gateways/GarantiPos.php` (+2 -1) 📝 `src/Gateways/InterPos.php` (+2 -1) 📝 `src/Gateways/KuveytPos.php` (+6 -3) 📝 `src/Gateways/PayFlexCPV4Pos.php` (+4 -2) 📝 `src/Gateways/PayFlexV4Pos.php` (+4 -2) 📝 `src/Gateways/PayForPos.php` (+3 -7) 📝 `src/Gateways/PosNet.php` (+6 -3) 📝 `src/Gateways/PosNetV1Pos.php` (+4 -2) 📝 `src/Gateways/ToslaPos.php` (+4 -2) 📝 `src/Gateways/VakifKatilimPos.php` (+6 -3) 📝 `tests/Unit/DataMapper/RequestDataMapper/EstPosRequestDataMapperTest.php` (+91 -27) _...and 22 more files_ </details> ### 📄 Description _No description provided_ --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-03-03 15:44:14 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

v2

v2-introduce-response-object

v1.8.0

issue-289-fix-kuveytpos-soap-calls

fix/phpstan-and-php8.5

v1.6

task/pacgage-upgrade

master-old-pkg

1.8.0

1.7.1

1.7.0

1.6.0

1.5.0

1.4.2

1.4.1

1.4.0

1.3.0

1.2.0

1.1.1

1.1.0

1.0.1

1.0.0

0.16.1

0.16.0

0.15.1

0.15.0

0.14.0

0.13.2

0.13.1

0.13.0

0.12.2

0.12.1

0.12.0

0.11.0

0.10.5

0.10.4

0.10.3

0.10.2

0.10.1

0.10.0

0.9.1

0.9.0

0.8.2

0.8.1

0.8.0

0.7.4

0.7.3

0.7.2

0.7.1

0.7.0

0.6.1

0.6.0

0.5.2

0.5.1

0.5.0

0.4.17

0.4.16

0.4.15

0.4.14

0.4.13

0.4.12

0.4.11

0.4.10

0.4.9

0.4.8

0.4.7

0.4.6

0.4.5

0.4.4

0.4.3

0.4.2

0.4.1

0.4.0

0.3.8

0.3.7

0.3.6

0.3.5

0.3.4

0.3.3

0.3.2

0.3.1

0.2.0

0.1.8

0.3.0

0.1.7

0.1.6

0.1.5

0.1.2

0.1.1

0.1.0

Labels

Clear labels   

PayFlexV4

  

TROY

  

akbankpos

  

bug

  

duplicate

  

enhancement

  

garanti

  

help wanted

  

isbank

  

kuveyt

  

payten

  

posnet

  

pull-request

Mirrored from GitHub Pull Request

  

vakifbank

  

ziraat

No labels

PayFlexV4

TROY

akbankpos

bug

duplicate

enhancement

garanti

help wanted

isbank

kuveyt

payten

posnet

pull-request

vakifbank

ziraat

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/pos#267

No description provided.