[PR #231] [MERGED] fix payflexv4pos issues #265

New issue

Closed

opened 2026-03-03 15:44:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:44:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/231
Author: @nuryagdym
Created: 8/12/2024
Status: ✅ Merged
Merged: 8/17/2024
Merged by: @nuryagdym

Base: master ← Head: 229-payflex-issues

📝 Commits (8)

2cd6f90 fix issue #229 payflexv4pos status request undefined index CurrencyAmount
bd10da2 fix issue #230 payflexv4pos payment hostdate format error
c90143f fix issue #230 payflexv4pos host date format error
d936c4e tests - more test coverage
b333850 payflexv4pos - throw exception for unimplemented methods
ff4a3c6 payflexv4pos - fix order status request with transaction_id
d2cfa26 test - more coverage
d740c95 styling - run rector

📊 Changes

16 files changed (+587 additions, -341 deletions)

View changed files

📝 config/pos_production.php (+1 -1)
📝 src/Crypt/PayFlexCPV4Crypt.php (+1 -1)
📝 src/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapper.php (+2 -1)
📝 src/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapper.php (+5 -0)
📝 src/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapper.php (+9 -4)
📝 src/Gateways/AbstractGateway.php (+1 -0)
📝 tests/Unit/Crypt/AkbankPosCryptTest.php (+1 -0)
📝 tests/Unit/Crypt/InterPosCryptTest.php (+22 -0)
📝 tests/Unit/Crypt/PayFlexCP4CryptTest.php (+17 -2)
📝 tests/Unit/Crypt/PosNetV1PosCryptTest.php (+12 -0)
📝 tests/Unit/DataMapper/RequestDataMapper/InterPosRequestDataMapperTest.php (+166 -167)
📝 tests/Unit/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapperTest.php (+173 -101)
📝 tests/Unit/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapperTest.php (+2 -0)
📝 tests/Unit/DataMapper/ResponseDataMapper/InterPosResponseDataMapperTest.php (+83 -56)
📝 tests/Unit/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapperTest.php (+77 -0)
📝 tests/Unit/DataMapper/ResponseDataMapper/VakifKatilimPosResponseDataMapperTest.php (+15 -8)

📄 Description

throw exception for unimplemented payments models 3d pay and 3d host
throw exception for and unimplemented PayFlexCPV4Crypt method check3DHash
fix order status is not considering transaction_id
fix issue #230
fix issue #229

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/231 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 8/12/2024 **Status:** ✅ Merged **Merged:** 8/17/2024 **Merged by:** [@nuryagdym](https://github.com/nuryagdym) **Base:** `master` ← **Head:** `229-payflex-issues` --- ### 📝 Commits (8) - [`2cd6f90`](https://github.com/mewebstudio/pos/commit/2cd6f90eacf87f768ae9c82d9af2a6f2a3f5b9f5) fix issue #229 payflexv4pos status request undefined index CurrencyAmount - [`bd10da2`](https://github.com/mewebstudio/pos/commit/bd10da28784e056a21a4b27ee927b981d973948e) fix issue #230 payflexv4pos payment hostdate format error - [`c90143f`](https://github.com/mewebstudio/pos/commit/c90143faf20ddd984d19407d3847cb8512f6b913) fix issue #230 payflexv4pos host date format error - [`d936c4e`](https://github.com/mewebstudio/pos/commit/d936c4e8ac923d2f29616c3c6164a3f6ce9f2fab) tests - more test coverage - [`b333850`](https://github.com/mewebstudio/pos/commit/b3338501b4748087dde6de1e2b2a61e40fe17383) payflexv4pos - throw exception for unimplemented methods - [`ff4a3c6`](https://github.com/mewebstudio/pos/commit/ff4a3c6ca54fd63b38cab4817007f912a5e96f9a) payflexv4pos - fix order status request with transaction_id - [`d2cfa26`](https://github.com/mewebstudio/pos/commit/d2cfa26e334bcf94c586139547d0c7c901ca9616) test - more coverage - [`d740c95`](https://github.com/mewebstudio/pos/commit/d740c95784a9bc057ac2859aaa219673d0f08e23) styling - run rector ### 📊 Changes **16 files changed** (+587 additions, -341 deletions) <details> <summary>View changed files</summary> 📝 `config/pos_production.php` (+1 -1) 📝 `src/Crypt/PayFlexCPV4Crypt.php` (+1 -1) 📝 `src/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapper.php` (+2 -1) 📝 `src/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapper.php` (+5 -0) 📝 `src/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapper.php` (+9 -4) 📝 `src/Gateways/AbstractGateway.php` (+1 -0) 📝 `tests/Unit/Crypt/AkbankPosCryptTest.php` (+1 -0) 📝 `tests/Unit/Crypt/InterPosCryptTest.php` (+22 -0) 📝 `tests/Unit/Crypt/PayFlexCP4CryptTest.php` (+17 -2) 📝 `tests/Unit/Crypt/PosNetV1PosCryptTest.php` (+12 -0) 📝 `tests/Unit/DataMapper/RequestDataMapper/InterPosRequestDataMapperTest.php` (+166 -167) 📝 `tests/Unit/DataMapper/RequestDataMapper/PayFlexV4PosRequestDataMapperTest.php` (+173 -101) 📝 `tests/Unit/DataMapper/ResponseDataMapper/GarantiPosResponseDataMapperTest.php` (+2 -0) 📝 `tests/Unit/DataMapper/ResponseDataMapper/InterPosResponseDataMapperTest.php` (+83 -56) 📝 `tests/Unit/DataMapper/ResponseDataMapper/PayFlexV4PosResponseDataMapperTest.php` (+77 -0) 📝 `tests/Unit/DataMapper/ResponseDataMapper/VakifKatilimPosResponseDataMapperTest.php` (+15 -8) </details> ### 📄 Description - throw exception for unimplemented payments models 3d pay and 3d host - throw exception for and unimplemented PayFlexCPV4Crypt method check3DHash - fix order status is not considering transaction_id - fix issue #230 - fix issue #229 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>