[PR #114] [MERGED] Rector and Vakifbank common payment integration #215

New issue

Closed

opened 2026-03-03 15:43:59 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:43:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/114
Author: @nuryagdym
Created: 2/5/2023
Status: ✅ Merged
Merged: 3/13/2023
Merged by: @nuryagdym

Base: master ← Head: rector-integration

📝 Commits (10+)

b123ea0 set up rector
a5173ec VakifBankPosRequestDataMapper fix order description
3e7a9d0 rector process src - first round
c8595d5 rector process examples - first round
0e6876c rector process test - first round
1a4a239 normalize mapInstallment method
7163ea5 normalize mapInstallment method
b80d593 rector round 2
b267700 get3DFormData() - throw exception if order or card data is not provided
c89bd4e rector round 3 - process response mappers

📊 Changes

149 files changed (+3252 additions, -999 deletions)

View changed files

📝 .github/ISSUE_TEMPLATE/hata-bildirimi-icin.md (+0 -0)
📝 .github/ISSUE_TEMPLATE/sorulariniz-icin.md (+0 -0)
📝 README.md (+2 -0)
📝 composer.json (+2 -1)
📝 config/pos.php (+18 -2)
📝 docs/CHANGELOG.md (+15 -0)
📝 examples/_common-codes/3d-host/index.php (+3 -3)
📝 examples/_common-codes/3d/form.php (+3 -3)
📝 examples/_common-codes/3d/index.php (+3 -3)
📝 examples/_common-codes/regular/form.php (+1 -1)
📝 examples/_templates/_credit_card_form.php (+0 -0)
📝 examples/_templates/_footer.php (+1 -1)
📝 examples/_templates/_header.php (+2 -1)
📝 examples/_templates/_payment_response.php (+4 -1)
📝 examples/_templates/_redirect_form.php (+1 -1)
📝 examples/_templates/_simple_response_dump.php (+0 -0)
📝 examples/akbank/3d-host/response.php (+1 -1)
📝 examples/akbank/3d-pay-hosting/response.php (+1 -1)
📝 examples/akbank/3d-pay/response.php (+1 -1)
📝 examples/akbank/3d/response.php (+1 -1)

...and 80 more files

📄 Description

Enable automatic code refactoring using Rector.
get3DFormData() - artık gereken kart veya sipariş bilgileri olmadan çağrıldığında istisna fırlatır.
VakifBankPosRequestDataMapper - OrderDescription tanımsız olma durumu giderildi.

more details in https://github.com/mewebstudio/pos/blob/master/docs/CHANGELOG.md

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/114 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 2/5/2023 **Status:** ✅ Merged **Merged:** 3/13/2023 **Merged by:** [@nuryagdym](https://github.com/nuryagdym) **Base:** `master` ← **Head:** `rector-integration` --- ### 📝 Commits (10+) - [`b123ea0`](https://github.com/mewebstudio/pos/commit/b123ea0d30dccd9154f465711b7ab5003c640ea6) set up rector - [`a5173ec`](https://github.com/mewebstudio/pos/commit/a5173eceee3c4b31d0b3c09ee107824f0acdbb12) VakifBankPosRequestDataMapper fix order description - [`3e7a9d0`](https://github.com/mewebstudio/pos/commit/3e7a9d0dd0d45acbd41d8f2bb586aed30c9c734f) rector process src - first round - [`c8595d5`](https://github.com/mewebstudio/pos/commit/c8595d5c0d45e918885ab72ec815e404fa18bae1) rector process examples - first round - [`0e6876c`](https://github.com/mewebstudio/pos/commit/0e6876c0e45036b6ab31b9d21a79c5a1af2334f4) rector process test - first round - [`1a4a239`](https://github.com/mewebstudio/pos/commit/1a4a2395ad94de121aae3229d9873b26d917f372) normalize mapInstallment method - [`7163ea5`](https://github.com/mewebstudio/pos/commit/7163ea59325c48794ad5e054c9c8afff4aa0a51b) normalize mapInstallment method - [`b80d593`](https://github.com/mewebstudio/pos/commit/b80d593034a741a33ef2920f0b632b0d90120b19) rector round 2 - [`b267700`](https://github.com/mewebstudio/pos/commit/b26770089afeb6661c69f17da94759b581786219) get3DFormData() - throw exception if order or card data is not provided - [`c89bd4e`](https://github.com/mewebstudio/pos/commit/c89bd4e97e3a859259d13fdeffe291e13bb1eae8) rector round 3 - process response mappers ### 📊 Changes **149 files changed** (+3252 additions, -999 deletions) <details> <summary>View changed files</summary> 📝 `.github/ISSUE_TEMPLATE/hata-bildirimi-icin.md` (+0 -0) 📝 `.github/ISSUE_TEMPLATE/sorulariniz-icin.md` (+0 -0) 📝 `README.md` (+2 -0) 📝 `composer.json` (+2 -1) 📝 `config/pos.php` (+18 -2) 📝 `docs/CHANGELOG.md` (+15 -0) 📝 `examples/_common-codes/3d-host/index.php` (+3 -3) 📝 `examples/_common-codes/3d/form.php` (+3 -3) 📝 `examples/_common-codes/3d/index.php` (+3 -3) 📝 `examples/_common-codes/regular/form.php` (+1 -1) 📝 `examples/_templates/_credit_card_form.php` (+0 -0) 📝 `examples/_templates/_footer.php` (+1 -1) 📝 `examples/_templates/_header.php` (+2 -1) 📝 `examples/_templates/_payment_response.php` (+4 -1) 📝 `examples/_templates/_redirect_form.php` (+1 -1) 📝 `examples/_templates/_simple_response_dump.php` (+0 -0) 📝 `examples/akbank/3d-host/response.php` (+1 -1) 📝 `examples/akbank/3d-pay-hosting/response.php` (+1 -1) 📝 `examples/akbank/3d-pay/response.php` (+1 -1) 📝 `examples/akbank/3d/response.php` (+1 -1) _...and 80 more files_ </details> ### 📄 Description - Enable automatic code refactoring using Rector. - `get3DFormData()` - artık gereken _kart_ veya _sipariş_ bilgileri olmadan çağrıldığında istisna fırlatır. - `VakifBankPosRequestDataMapper` - `OrderDescription` tanımsız olma durumu giderildi. more details in https://github.com/mewebstudio/pos/blob/master/docs/CHANGELOG.md --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>