[PR #69] [MERGED] Fixes and improvements in EstPos and PosNet #193

New issue

Closed

opened 2026-03-03 15:43:52 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:43:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/69
Author: @nuryagdym
Created: 4/18/2022
Status: ✅ Merged
Merged: 4/18/2022
Merged by: @nuryagdym

Base: master ← Head: posnet-refactor-oostransaction-method

📝 Commits (10+)

e49ca81 refactored PosNet::getOosTransactionData() to be more testable
c5e2f28 examples - added valid EstPos credentials
e1d6d0c EstPos::map3DPaymentData() fix order_id is null upon authorization fail
de90a00 examples - updated est pos credentials with valid ones
6eff75b EstPos - fix errors when mapping 3D Host response
be7ffef EstPos - fix undefined index in 3d and 3d_pay response mapping, and refactoring, added more tests
bc7bf5a EstPos - fix refund request error
b87233a EstPos - refactor and test cancel/refund/history/status
b0b2985 examples - fix ykb uri
1e4e6ea remove accidentally committed changes

📊 Changes

12 files changed (+1196 additions, -205 deletions)

View changed files

📝 examples/akbank/3d-host/_config.php (+5 -4)
📝 examples/akbank/3d-pay/_config.php (+5 -4)
📝 examples/akbank/3d/_config.php (+4 -4)
📝 examples/akbank/regular/_config.php (+3 -3)
📝 examples/akbank/regular/refund.php (+1 -0)
📝 examples/ykb/regular/_config.php (+1 -1)
📝 src/Factory/PosFactory.php (+1 -1)
📝 src/Gateways/EstPos.php (+196 -78)
📝 src/Gateways/PosNet.php (+31 -18)
📝 tests/Gateways/EstPostTest.php (+904 -83)
📝 tests/Gateways/PosNetTest.php (+37 -1)
📝 tests/Gateways/VakifBankPosTest.php (+8 -8)

📄 Description

EstPos - fix refund request error.
EstPos - refactor status/cancel/refund/history methods.
EstPos - fix undefined index error on 3d and 3d_pay requests.
EstPos - fix response mapping of 3d_host payment.
examples - added valid EstPos test crendetials.
examples - fix ykb uri.
PosNet - updated getOosTransactionData() method to be more testable.
Added more unit tests for PosNet and EstPos

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/69 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 4/18/2022 **Status:** ✅ Merged **Merged:** 4/18/2022 **Merged by:** [@nuryagdym](https://github.com/nuryagdym) **Base:** `master` ← **Head:** `posnet-refactor-oostransaction-method` --- ### 📝 Commits (10+) - [`e49ca81`](https://github.com/mewebstudio/pos/commit/e49ca81613c51e4e754b8685bd7519c1fcc1aa8b) refactored PosNet::getOosTransactionData() to be more testable - [`c5e2f28`](https://github.com/mewebstudio/pos/commit/c5e2f28b79a07a344d9397f8d481500db0b70c37) examples - added valid EstPos credentials - [`e1d6d0c`](https://github.com/mewebstudio/pos/commit/e1d6d0caff7ed931ca4897b3d2be4268ab3144d8) EstPos::map3DPaymentData() fix order_id is null upon authorization fail - [`de90a00`](https://github.com/mewebstudio/pos/commit/de90a00a5c60f225adfe5cee4a4a99179dfdcdeb) examples - updated est pos credentials with valid ones - [`6eff75b`](https://github.com/mewebstudio/pos/commit/6eff75bbf3a7df106297bc03b7c22f75bd28711b) EstPos - fix errors when mapping 3D Host response - [`be7ffef`](https://github.com/mewebstudio/pos/commit/be7ffef66748669e4a38e81323d76e2c6571e5ca) EstPos - fix undefined index in 3d and 3d_pay response mapping, and refactoring, added more tests - [`bc7bf5a`](https://github.com/mewebstudio/pos/commit/bc7bf5ad92c2356dd024db0337dabe84e19bc659) EstPos - fix refund request error - [`b87233a`](https://github.com/mewebstudio/pos/commit/b87233a56a3f0a116338247d9bf253c9f4e04bd3) EstPos - refactor and test cancel/refund/history/status - [`b0b2985`](https://github.com/mewebstudio/pos/commit/b0b298518b047ad80037b1b2fbeac12a6ef47be4) examples - fix ykb uri - [`1e4e6ea`](https://github.com/mewebstudio/pos/commit/1e4e6eac1e00852b0d6c12260dfd89316f5c3ee1) remove accidentally committed changes ### 📊 Changes **12 files changed** (+1196 additions, -205 deletions) <details> <summary>View changed files</summary> 📝 `examples/akbank/3d-host/_config.php` (+5 -4) 📝 `examples/akbank/3d-pay/_config.php` (+5 -4) 📝 `examples/akbank/3d/_config.php` (+4 -4) 📝 `examples/akbank/regular/_config.php` (+3 -3) 📝 `examples/akbank/regular/refund.php` (+1 -0) 📝 `examples/ykb/regular/_config.php` (+1 -1) 📝 `src/Factory/PosFactory.php` (+1 -1) 📝 `src/Gateways/EstPos.php` (+196 -78) 📝 `src/Gateways/PosNet.php` (+31 -18) 📝 `tests/Gateways/EstPostTest.php` (+904 -83) 📝 `tests/Gateways/PosNetTest.php` (+37 -1) 📝 `tests/Gateways/VakifBankPosTest.php` (+8 -8) </details> ### 📄 Description - **EstPos** - fix _refund_ request error. - **EstPos** - refactor _status/cancel/refund/history_ methods. - **EstPos** - fix undefined index error on **3d** and **3d_pay** requests. - **EstPos** - fix response mapping of **3d_host** payment. - **examples** - added valid **EstPos** test crendetials. - **examples** - fix ykb uri. - **PosNet** - updated getOosTransactionData() method to be more testable. - Added more unit tests for **PosNet** and **EstPos** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>