[PR #68] [MERGED] Refactor hash related methods #192

Closed
opened 2026-03-03 15:43:52 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/68
Author: @nuryagdym
Created: 4/16/2022
Status: Merged
Merged: 4/16/2022
Merged by: @nuryagdym

Base: masterHead: refactor-hash-realted-methods


📝 Commits (3)

  • f0996ea refactored hash methods to be more testable
  • f6b516c examples - removed unused redis session configs
  • a1b3894 examples - added valid test card for garanti

📊 Changes

14 files changed (+371 additions, -155 deletions)

View changed files

📝 examples/_main_config.php (+1 -11)
📝 examples/garanti/_payment_config.php (+4 -4)
📝 src/Gateways/AbstractGateway.php (+1 -0)
📝 src/Gateways/EstPos.php (+34 -11)
📝 src/Gateways/GarantiPos.php (+56 -32)
📝 src/Gateways/InterPos.php (+22 -17)
📝 src/Gateways/KuveytPos.php (+13 -13)
📝 src/Gateways/PayForPos.php (+38 -19)
📝 src/Gateways/PosNet.php (+56 -30)
📝 tests/Gateways/EstPostTest.php (+49 -4)
📝 tests/Gateways/GarantiPosTest.php (+49 -0)
📝 tests/Gateways/InterPosTest.php (+16 -3)
📝 tests/Gateways/PayForTest.php (+7 -6)
📝 tests/Gateways/PosNetTest.php (+25 -5)

📄 Description

  • updated hash create and hash check methods to be more testable
  • added more unit tests for hash create and check methods

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/68 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 4/16/2022 **Status:** ✅ Merged **Merged:** 4/16/2022 **Merged by:** [@nuryagdym](https://github.com/nuryagdym) **Base:** `master` ← **Head:** `refactor-hash-realted-methods` --- ### 📝 Commits (3) - [`f0996ea`](https://github.com/mewebstudio/pos/commit/f0996eaf5a9c2c9014fd90d41cdc980874147c38) refactored hash methods to be more testable - [`f6b516c`](https://github.com/mewebstudio/pos/commit/f6b516cf684edc3c0e8df9ad86d7c267ce844595) examples - removed unused redis session configs - [`a1b3894`](https://github.com/mewebstudio/pos/commit/a1b3894fdafe5e1d7f9d4dd012bff5111df57c23) examples - added valid test card for garanti ### 📊 Changes **14 files changed** (+371 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `examples/_main_config.php` (+1 -11) 📝 `examples/garanti/_payment_config.php` (+4 -4) 📝 `src/Gateways/AbstractGateway.php` (+1 -0) 📝 `src/Gateways/EstPos.php` (+34 -11) 📝 `src/Gateways/GarantiPos.php` (+56 -32) 📝 `src/Gateways/InterPos.php` (+22 -17) 📝 `src/Gateways/KuveytPos.php` (+13 -13) 📝 `src/Gateways/PayForPos.php` (+38 -19) 📝 `src/Gateways/PosNet.php` (+56 -30) 📝 `tests/Gateways/EstPostTest.php` (+49 -4) 📝 `tests/Gateways/GarantiPosTest.php` (+49 -0) 📝 `tests/Gateways/InterPosTest.php` (+16 -3) 📝 `tests/Gateways/PayForTest.php` (+7 -6) 📝 `tests/Gateways/PosNetTest.php` (+25 -5) </details> ### 📄 Description - updated hash create and hash check methods to be more testable - added more unit tests for hash create and check methods --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-03 15:43:52 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/pos#192
No description provided.