[PR #16] [MERGED] code refactoring and improvement #167

New issue

Closed

opened 2026-03-03 15:43:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:43:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/16
Author: @nuryagdym
Created: 11/22/2020
Status: ✅ Merged
Merged: 12/3/2020
Merged by: @mewebstudio

Base: master ← Head: master

📝 Commits (5)

16d79e9 code refactoring and improvement
4af43c1 fix refund example
3fd2e34 fix yapikredi example
b5472f4 update yapikredi URLs
436133d update README.md

📊 Changes

92 files changed (+6313 additions, -4919 deletions)

View changed files

📝 README.md (+20 -31)
📝 config/pos.php (+18 -31)
📝 examples/_main_config.php (+3 -0)
📝 examples/akbank/3d-pay/_config.php (+4 -10)
📝 examples/akbank/3d-pay/form.php (+4 -5)
📝 examples/akbank/3d-pay/response.php (+1 -1)
📝 examples/akbank/3d/_config.php (+4 -13)
📝 examples/akbank/3d/form.php (+3 -4)
📝 examples/akbank/3d/index.php (+5 -5)
📝 examples/akbank/3d/response.php (+1 -1)
📝 examples/akbank/regular/_config.php (+5 -13)
📝 examples/akbank/regular/cancel.php (+7 -4)
📝 examples/akbank/regular/direct.php (+1 -2)
📝 examples/akbank/regular/history.php (+3 -3)
📝 examples/akbank/regular/post.php (+5 -5)
📝 examples/akbank/regular/refund.php (+6 -5)
📝 examples/akbank/regular/response.php (+3 -4)
📝 examples/akbank/regular/status.php (+8 -6)
📝 examples/finansbank-payfor/3d-host/_config.php (+3 -11)
📝 examples/finansbank-payfor/3d-host/index.php (+2 -3)

...and 72 more files

📄 Description

Created Account classes for each POS Gateways
Removed src/Pos.php and src/PosHelpersTrait.php, instead added src/Gateways/AbstractGateway.php and src/Factory/PosFactory.php
more unite tests
moved currencies inside Pos Gateway classes because PosNet currencies are different, but still can be overrided from configs.
code refactoring and improvement

Degisiklikleri PayFor icin denedim calisiyor. Digerlerinde belli bire yere kadar test edebildim, hesap ve kart bilgileri olsa digerlerinde de test ederim.
Genel olarak kontrolleri unit testlerle desteklemeye calistim.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/16 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 11/22/2020 **Status:** ✅ Merged **Merged:** 12/3/2020 **Merged by:** [@mewebstudio](https://github.com/mewebstudio) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`16d79e9`](https://github.com/mewebstudio/pos/commit/16d79e9b7513a4e9a758487f7add0f7ee6e728bb) code refactoring and improvement - [`4af43c1`](https://github.com/mewebstudio/pos/commit/4af43c1637594321e860afcf17a147629af4de55) fix refund example - [`3fd2e34`](https://github.com/mewebstudio/pos/commit/3fd2e34910c6aa1f8c0d7b21162c0e9398d90117) fix yapikredi example - [`b5472f4`](https://github.com/mewebstudio/pos/commit/b5472f466e35965b3983f5a68e20acd72ded68ef) update yapikredi URLs - [`436133d`](https://github.com/mewebstudio/pos/commit/436133db6e832ce03761f45bf1090fbd2c469bb1) update README.md ### 📊 Changes **92 files changed** (+6313 additions, -4919 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+20 -31) 📝 `config/pos.php` (+18 -31) 📝 `examples/_main_config.php` (+3 -0) 📝 `examples/akbank/3d-pay/_config.php` (+4 -10) 📝 `examples/akbank/3d-pay/form.php` (+4 -5) 📝 `examples/akbank/3d-pay/response.php` (+1 -1) 📝 `examples/akbank/3d/_config.php` (+4 -13) 📝 `examples/akbank/3d/form.php` (+3 -4) 📝 `examples/akbank/3d/index.php` (+5 -5) 📝 `examples/akbank/3d/response.php` (+1 -1) 📝 `examples/akbank/regular/_config.php` (+5 -13) 📝 `examples/akbank/regular/cancel.php` (+7 -4) 📝 `examples/akbank/regular/direct.php` (+1 -2) 📝 `examples/akbank/regular/history.php` (+3 -3) 📝 `examples/akbank/regular/post.php` (+5 -5) 📝 `examples/akbank/regular/refund.php` (+6 -5) 📝 `examples/akbank/regular/response.php` (+3 -4) 📝 `examples/akbank/regular/status.php` (+8 -6) 📝 `examples/finansbank-payfor/3d-host/_config.php` (+3 -11) 📝 `examples/finansbank-payfor/3d-host/index.php` (+2 -3) _...and 72 more files_ </details> ### 📄 Description - Created Account classes for each POS Gateways - Removed `src/Pos.php` and `src/PosHelpersTrait.php`, instead added `src/Gateways/AbstractGateway.php` and `src/Factory/PosFactory.php` - more unite tests - moved currencies inside Pos Gateway classes because PosNet currencies are different, but still can be overrided from configs. - code refactoring and improvement Degisiklikleri PayFor icin denedim calisiyor. Digerlerinde belli bire yere kadar test edebildim, hesap ve kart bilgileri olsa digerlerinde de test ederim. Genel olarak kontrolleri unit testlerle desteklemeye calistim. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>