[PR #7] [MERGED] replace mcrypt and some fixes, enhancements, unit tests #161

New issue

Closed

opened 2026-03-03 15:43:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 15:43:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/mewebstudio/pos/pull/7
Author: @nuryagdym
Created: 4/5/2020
Status: ✅ Merged
Merged: 4/10/2020
Merged by: @mewebstudio

Base: master ← Head: master

📝 Commits (10+)

1877448 replace deprecated mcrypt with openssl. and other minor changes
0946042 remove delete method calls
9ec08b0 PHPUnit init and PosNetCrypt.php unit tests
4831b0f PHPUnit more tests
a6c30b7 update Yapikredi URLS and add TEB bank
7487ad4 simplify check3Dhash method and PHPUnit test for it
1d1b092 fix response parameter names
70c6746 add MAC field to requests and verify received MAC
02013f2 update symfony/serializer to 5.0
2079c14 comparing hostnames causes 3Dhash verification to fail in some cases. For example, in the Yapikredi documentation the url we need to use is

📊 Changes

14 files changed (+1160 additions, -451 deletions)

View changed files

📝 composer.json (+6 -3)
📝 config/pos.php (+23 -4)
➕ phpunit.xml (+25 -0)
📝 src/EstPos.php (+342 -300)
📝 src/GarantiPos.php (+43 -6)
📝 src/Pos.php (+35 -0)
📝 src/PosHelpersTrait.php (+19 -5)
📝 src/PosNet.php (+148 -62)
📝 src/PosNetCrypt.php (+33 -71)
➕ tests/EstPostTest.php (+149 -0)
➕ tests/GarantiPosTest.php (+98 -0)
➕ tests/PosNetCryptTest.php (+35 -0)
➕ tests/PosNetTest.php (+110 -0)
➕ tests/PosTest.php (+94 -0)

📄 Description

Production ortamda Yapikredi testleri yapildi:

3d payment calisiyor
order status calisiyor
elimdeki sanalpos 3d_pay ve regular payment desteklemedigi icin bunlarin testini yapamadim.
order refund/cancel'i de elimdeki sanal posta izin olmadigi icin onun testlerini yapamadim.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mewebstudio/pos/pull/7 **Author:** [@nuryagdym](https://github.com/nuryagdym) **Created:** 4/5/2020 **Status:** ✅ Merged **Merged:** 4/10/2020 **Merged by:** [@mewebstudio](https://github.com/mewebstudio) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (10+) - [`1877448`](https://github.com/mewebstudio/pos/commit/18774482330afabd37ccdeed322917ca0848dade) replace deprecated mcrypt with openssl. and other minor changes - [`0946042`](https://github.com/mewebstudio/pos/commit/0946042786e7c6f6a622a522e5471952cf27542e) remove delete method calls - [`9ec08b0`](https://github.com/mewebstudio/pos/commit/9ec08b016ca8ce469793e75a945491fd16cfc692) PHPUnit init and PosNetCrypt.php unit tests - [`4831b0f`](https://github.com/mewebstudio/pos/commit/4831b0fd640eaaf597cdb7d11a67dc190629ccdb) PHPUnit more tests - [`a6c30b7`](https://github.com/mewebstudio/pos/commit/a6c30b7d187401b4c9b372b3d54f7587f502029a) update Yapikredi URLS and add TEB bank - [`7487ad4`](https://github.com/mewebstudio/pos/commit/7487ad48f7a1de93b9f52f2add2b9c6ff5a502ce) simplify check3Dhash method and PHPUnit test for it - [`1d1b092`](https://github.com/mewebstudio/pos/commit/1d1b0929452a8ecd2502583a666c2fa9213f4440) fix response parameter names - [`70c6746`](https://github.com/mewebstudio/pos/commit/70c67463a35abff5676cc69aa35aee4302aee012) add MAC field to requests and verify received MAC - [`02013f2`](https://github.com/mewebstudio/pos/commit/02013f21b9c237743e2e14f3ca354c223a519592) update symfony/serializer to 5.0 - [`2079c14`](https://github.com/mewebstudio/pos/commit/2079c1435a06340f89b7aff2e46e180ff6a66f9a) comparing hostnames causes 3Dhash verification to fail in some cases. For example, in the Yapikredi documentation the url we need to use is ### 📊 Changes **14 files changed** (+1160 additions, -451 deletions) <details> <summary>View changed files</summary> 📝 `composer.json` (+6 -3) 📝 `config/pos.php` (+23 -4) ➕ `phpunit.xml` (+25 -0) 📝 `src/EstPos.php` (+342 -300) 📝 `src/GarantiPos.php` (+43 -6) 📝 `src/Pos.php` (+35 -0) 📝 `src/PosHelpersTrait.php` (+19 -5) 📝 `src/PosNet.php` (+148 -62) 📝 `src/PosNetCrypt.php` (+33 -71) ➕ `tests/EstPostTest.php` (+149 -0) ➕ `tests/GarantiPosTest.php` (+98 -0) ➕ `tests/PosNetCryptTest.php` (+35 -0) ➕ `tests/PosNetTest.php` (+110 -0) ➕ `tests/PosTest.php` (+94 -0) </details> ### 📄 Description Production ortamda Yapikredi testleri yapildi: 1. 3d payment calisiyor 2. order status calisiyor 3. elimdeki sanalpos 3d_pay ve regular payment desteklemedigi icin bunlarin testini yapamadim. 4. order refund/cancel'i de elimdeki sanal posta izin olmadigi icin onun testlerini yapamadim. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>