starred/planning-with-files

Fork 0

mirror of https://github.com/OthmanAdi/planning-with-files.git synced 2026-04-26 00:16:01 +03:00

[GH-ISSUE #45] The implementation of the script check-complete.sh is not complete. #33

New issue

Closed

opened 2026-03-03 18:50:09 +03:00 by kerem · 2 comments

kerem commented

2026-03-03 18:50:09 +03:00

Owner

Originally created by @amazingchow on GitHub (Jan 20, 2026).
Original GitHub issue: https://github.com/OthmanAdi/planning-with-files/issues/45

Phases in my task_plan.md,

## Phases

### Phase 1: Investigate Current Code [complete]
- Read all affected component files
- Document current implementation issues
- Identify root causes

### Phase 2: Fix Bug 1 - Table List Layout [complete]
- Fix LeftPanel.vue layout
- Ensure icon + table name + DDL button on same line
- Test display with long table names

### Phase 3: Fix Bug 2 - Column Names Display [complete]
- Ensure full column names visible in TableDataViewer
- Implement value truncation with click-to-expand
- Test with long column names and values

### Phase 4: Fix Bug 3 - DDL SQL Display [complete]
- Debug why DDL SQL not showing
- Fix TableDDLViewer rendering
- Test DDL display

### Phase 5: Fix Bug 4 - Query History Copy [complete]
- Fix copy button in QueryHistory
- Test clipboard functionality
- Verify copy operation works

### Phase 6: Testing & Verification [complete]
- Test all fixes together
- Verify no regressions
- Document changes

I must make the following corrections to successfully check task_pan.md.

TOTAL=$(grep -c "### Phase" "task_plan.md" || true)
COMPLETE=$(grep -cF "**Status:** complete" "task_plan.md" || true)
if [ "$COMPLETE" -eq 0 ]; then
    COMPLETE=$(grep -cF "[complete]" "task_plan.md" || true)
fi
IN_PROGRESS=$(grep -cF "**Status:** in_progress" "task_plan.md" || true)
if [ "$IN_PROGRESS" -eq 0 ]; then
    IN_PROGRESS=$(grep -cF "[in_progress]" "task_plan.md" || true)
fi
PENDING=$(grep -cF "**Status:** pending" "task_plan.md" || true)
if [ "$PENDING" -eq 0 ]; then
    PENDING=$(grep -cF "[pending]" "task_plan.md" || true)
fi

Obviously, my implementation is also incomplete. I hope the official team can provide a universal solution.

Originally created by @amazingchow on GitHub (Jan 20, 2026). Original GitHub issue: https://github.com/OthmanAdi/planning-with-files/issues/45 **Phases** in my task_plan.md, ``` ## Phases ### Phase 1: Investigate Current Code [complete] - Read all affected component files - Document current implementation issues - Identify root causes ### Phase 2: Fix Bug 1 - Table List Layout [complete] - Fix LeftPanel.vue layout - Ensure icon + table name + DDL button on same line - Test display with long table names ### Phase 3: Fix Bug 2 - Column Names Display [complete] - Ensure full column names visible in TableDataViewer - Implement value truncation with click-to-expand - Test with long column names and values ### Phase 4: Fix Bug 3 - DDL SQL Display [complete] - Debug why DDL SQL not showing - Fix TableDDLViewer rendering - Test DDL display ### Phase 5: Fix Bug 4 - Query History Copy [complete] - Fix copy button in QueryHistory - Test clipboard functionality - Verify copy operation works ### Phase 6: Testing & Verification [complete] - Test all fixes together - Verify no regressions - Document changes ``` I must make the following corrections to successfully check task_pan.md. ```shell TOTAL=$(grep -c "### Phase" "task_plan.md" || true) COMPLETE=$(grep -cF "**Status:** complete" "task_plan.md" || true) if [ "$COMPLETE" -eq 0 ]; then COMPLETE=$(grep -cF "[complete]" "task_plan.md" || true) fi IN_PROGRESS=$(grep -cF "**Status:** in_progress" "task_plan.md" || true) if [ "$IN_PROGRESS" -eq 0 ]; then IN_PROGRESS=$(grep -cF "[in_progress]" "task_plan.md" || true) fi PENDING=$(grep -cF "**Status:** pending" "task_plan.md" || true) if [ "$PENDING" -eq 0 ]; then PENDING=$(grep -cF "[pending]" "task_plan.md" || true) fi ``` Obviously, my implementation is also incomplete. I hope the official team can provide a universal solution.

kerem closed this issue

2026-03-03 18:50:09 +03:00

kerem commented

2026-03-03 18:50:10 +03:00

Author

Owner

@OthmanAdi commented on GitHub (Jan 22, 2026):

You're Right - The Script Needs to Support Multiple Formats

Thank you @amazingchow for this detailed report! You've identified a real limitation.

The Problem

The current script only checks for:

**Status:** complete

But users also use inline format:

### Phase 1: Investigate Current Code [complete]

The Fix

Here's the corrected logic that supports both formats:

# Count phases
TOTAL=$(grep -c "### Phase" "$PLAN_FILE" || true)

# Check for **Status:** format
COMPLETE=$(grep -cF "**Status:** complete" "$PLAN_FILE" || true)

# Also check for [complete] inline format
COMPLETE_INLINE=$(grep -c "\[complete\]" "$PLAN_FILE" || true)

# Use whichever format is present
if [ "$COMPLETE" -eq 0 ]; then
    COMPLETE=$COMPLETE_INLINE
fi

# Same for in_progress and pending
IN_PROGRESS=$(grep -cF "**Status:** in_progress" "$PLAN_FILE" || true)
if [ "$IN_PROGRESS" -eq 0 ]; then
    IN_PROGRESS=$(grep -c "\[in_progress\]" "$PLAN_FILE" || true)
fi

PENDING=$(grep -cF "**Status:** pending" "$PLAN_FILE" || true)
if [ "$PENDING" -eq 0 ]; then
    PENDING=$(grep -c "\[pending\]" "$PLAN_FILE" || true)
fi

Supported Status Formats

Format	Example
Bold Status	`Status: complete`
Inline Bracket	`### Phase 1: Name [complete]`
Markdown Checkbox	`- [x] Phase 1` (future)

I'll include this fix in the next release. Your suggested approach is correct!

Thanks for the contribution! 🙏

@OthmanAdi commented on GitHub (Jan 22, 2026): ## You're Right - The Script Needs to Support Multiple Formats Thank you @amazingchow for this detailed report! You've identified a real limitation. ### The Problem The current script only checks for: ``` **Status:** complete ``` But users also use inline format: ``` ### Phase 1: Investigate Current Code [complete] ``` ### The Fix Here's the corrected logic that supports both formats: ```bash # Count phases TOTAL=$(grep -c "### Phase" "$PLAN_FILE" || true) # Check for **Status:** format COMPLETE=$(grep -cF "**Status:** complete" "$PLAN_FILE" || true) # Also check for [complete] inline format COMPLETE_INLINE=$(grep -c "\[complete\]" "$PLAN_FILE" || true) # Use whichever format is present if [ "$COMPLETE" -eq 0 ]; then COMPLETE=$COMPLETE_INLINE fi # Same for in_progress and pending IN_PROGRESS=$(grep -cF "**Status:** in_progress" "$PLAN_FILE" || true) if [ "$IN_PROGRESS" -eq 0 ]; then IN_PROGRESS=$(grep -c "\[in_progress\]" "$PLAN_FILE" || true) fi PENDING=$(grep -cF "**Status:** pending" "$PLAN_FILE" || true) if [ "$PENDING" -eq 0 ]; then PENDING=$(grep -c "\[pending\]" "$PLAN_FILE" || true) fi ``` ### Supported Status Formats | Format | Example | |--------|---------| | Bold Status | `**Status:** complete` | | Inline Bracket | `### Phase 1: Name [complete]` | | Markdown Checkbox | `- [x] Phase 1` (future) | I'll include this fix in the next release. Your suggested approach is correct! Thanks for the contribution! 🙏

kerem commented

2026-03-03 18:50:10 +03:00

Author

Owner

@OthmanAdi commented on GitHub (Feb 4, 2026):

The fix has now been applied to master — thanks again @amazingchow!

Both check-complete.sh and check-complete.ps1 now support:

**Status:** complete (bold format)
### Phase 1: Name [complete] (inline bracket format)

Updated all 21 script copies across every IDE folder.

@OthmanAdi commented on GitHub (Feb 4, 2026): The fix has now been applied to master — thanks again @amazingchow! Both `check-complete.sh` and `check-complete.ps1` now support: 1. `**Status:** complete` (bold format) 2. `### Phase 1: Name [complete]` (inline bracket format) Updated all 21 script copies across every IDE folder.

kerem referenced this issue

2026-03-03 18:50:23 +03:00

[PR #33] [MERGED] feat: Add session recovery after /clear (v2.2.0) #62

No labels

bug

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/planning-with-files#33

No description provided.

Rows
Columns