[GH-ISSUE #111] ffmpeg binary included #87

New issue

Closed

opened 2026-02-25 23:40:38 +03:00 by kerem · 1 comment

kerem commented

2026-02-25 23:40:38 +03:00

Owner

Originally created by @sneak on GitHub (Mar 6, 2020).
Original GitHub issue: https://github.com/HaschekSolutions/pictshare/issues/111

There is an ffmpeg binary in bin. Without decompiling it, how am I to know it is safe to use? For this reason I have to stop using the project - it would be better to use system ffmpeg and simply add a mention that it needs to be installed in the README (and install it in the Dockerfile).

Originally created by @sneak on GitHub (Mar 6, 2020). Original GitHub issue: https://github.com/HaschekSolutions/pictshare/issues/111 There is an ffmpeg binary in `bin`. Without decompiling it, how am I to know it is safe to use? For this reason I have to stop using the project - it would be better to use system ffmpeg and simply add a mention that it needs to be installed in the `README` (and install it in the `Dockerfile`).

kerem closed this issue

2026-02-25 23:40:38 +03:00

kerem commented

2026-02-25 23:40:39 +03:00

Author

Owner

@geek-at commented on GitHub (Mar 6, 2020):

As stated in the INSTALL.md the binary is from https://www.johnvansickle.com/ffmpeg/ and you can check the hashes to verify it's not modified.

But of course you can link your own binary (like the one on your system) using the CONFIG setting FFMPEG_BINARY which is the absolute path to your own binary. This is actually used in the Docker container because the provided binary is only for x64 CPUs and the Docker image for ARM will use the locally installed ffmpeg (if available)

@geek-at commented on GitHub (Mar 6, 2020): As stated [in the INSTALL.md](https://github.com/HaschekSolutions/pictshare/blob/master/rtfm/INSTALL.md) the binary is from https://www.johnvansickle.com/ffmpeg/ and you can check the hashes to verify it's not modified. But of course you can link your own binary (like the one on your system) using the [CONFIG](https://github.com/HaschekSolutions/pictshare/blob/master/rtfm/CONFIG.md) setting `FFMPEG_BINARY` which is the absolute path to your own binary. This [is actually used](https://github.com/HaschekSolutions/PictShare-Docker/blob/master/rootfs/pictshare.sh#L58) in the Docker container because the provided binary is only for x64 CPUs and the Docker image for ARM will use the locally installed ffmpeg (if available)

kerem referenced this issue

2026-02-27 12:43:26 +03:00

[GH-ISSUE #87] Limit upload types by config keys #359

kerem referenced this issue

2026-02-27 12:43:29 +03:00

[GH-ISSUE #87] Limit upload types by config keys #362

kerem referenced this issue

2026-02-27 12:43:33 +03:00

[GH-ISSUE #87] Limit upload types by config keys #365