[PR #60] [CLOSED] Refactor the image filters #148

New issue

Closed

opened 2026-02-25 23:40:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:40:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/HaschekSolutions/pictshare/pull/60
Author: @birkett
Created: 6/22/2018
Status: ❌ Closed

Base: master ← Head: refactoring1

📝 Commits (4)

7ea14ce CS fixer, PSR2.
46c1bcc Refactor the filters.
81b43d9 Update README for PHP7 requirement.
b713e9e Filter fixes.

📊 Changes

46 files changed (+3676 additions, -2538 deletions)

View changed files

➕ Classes/FilterFactory.php (+68 -0)
➕ Classes/Filters/AbstractFilter.php (+110 -0)
➕ Classes/Filters/AquaFilter.php (+48 -0)
➕ Classes/Filters/BlurFilter.php (+115 -0)
➕ Classes/Filters/BoostFilter.php (+45 -0)
➕ Classes/Filters/BrightnessFilter.php (+36 -0)
➕ Classes/Filters/BubblesFilter.php (+81 -0)
➕ Classes/Filters/ColorizeFilter.php (+72 -0)
➕ Classes/Filters/ContrastFilter.php (+36 -0)
➕ Classes/Filters/CoolFilter.php (+41 -0)
➕ Classes/Filters/EdgeDetectFilter.php (+26 -0)
➕ Classes/Filters/EmbossFilter.php (+46 -0)
➕ Classes/Filters/FilterInterface.php (+54 -0)
➕ Classes/Filters/FuzzyFilter.php (+46 -0)
➕ Classes/Filters/GrayFilter.php (+41 -0)
➕ Classes/Filters/GrayscaleFilter.php (+26 -0)
➕ Classes/Filters/LightFilter.php (+57 -0)
➕ Classes/Filters/NegativeFilter.php (+26 -0)
➕ Classes/Filters/OldOneFilter.php (+63 -0)
➕ Classes/Filters/OldThreeFilter.php (+72 -0)

...and 26 more files

📄 Description

Split up and re-factor the image filters.
Each filter is it's own class, inheriting from an AbstractFilter, and FilterInterface.
Filters are created using a new FilterFactory.

This PR also introduces the namespace auto loader.

Breaking changes: PHP 7.0 required (type hints, strict types)
Functionality changes: none

Recommend a full test of all filters before merging.

(This PR is branched from the PSR2 work - merge that one first).

Linking #57

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/HaschekSolutions/pictshare/pull/60 **Author:** [@birkett](https://github.com/birkett) **Created:** 6/22/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `refactoring1` --- ### 📝 Commits (4) - [`7ea14ce`](https://github.com/HaschekSolutions/pictshare/commit/7ea14ce486f4309e2f28658705dff6f079652d24) CS fixer, PSR2. - [`46c1bcc`](https://github.com/HaschekSolutions/pictshare/commit/46c1bcc09f905ae4f6482fa2995b6125196f0bae) Refactor the filters. - [`81b43d9`](https://github.com/HaschekSolutions/pictshare/commit/81b43d97e7231d487c754f6d32d1a134ef3277c7) Update README for PHP7 requirement. - [`b713e9e`](https://github.com/HaschekSolutions/pictshare/commit/b713e9e214670c98e60c70aa99b0a5b772585101) Filter fixes. ### 📊 Changes **46 files changed** (+3676 additions, -2538 deletions) <details> <summary>View changed files</summary> ➕ `Classes/FilterFactory.php` (+68 -0) ➕ `Classes/Filters/AbstractFilter.php` (+110 -0) ➕ `Classes/Filters/AquaFilter.php` (+48 -0) ➕ `Classes/Filters/BlurFilter.php` (+115 -0) ➕ `Classes/Filters/BoostFilter.php` (+45 -0) ➕ `Classes/Filters/BrightnessFilter.php` (+36 -0) ➕ `Classes/Filters/BubblesFilter.php` (+81 -0) ➕ `Classes/Filters/ColorizeFilter.php` (+72 -0) ➕ `Classes/Filters/ContrastFilter.php` (+36 -0) ➕ `Classes/Filters/CoolFilter.php` (+41 -0) ➕ `Classes/Filters/EdgeDetectFilter.php` (+26 -0) ➕ `Classes/Filters/EmbossFilter.php` (+46 -0) ➕ `Classes/Filters/FilterInterface.php` (+54 -0) ➕ `Classes/Filters/FuzzyFilter.php` (+46 -0) ➕ `Classes/Filters/GrayFilter.php` (+41 -0) ➕ `Classes/Filters/GrayscaleFilter.php` (+26 -0) ➕ `Classes/Filters/LightFilter.php` (+57 -0) ➕ `Classes/Filters/NegativeFilter.php` (+26 -0) ➕ `Classes/Filters/OldOneFilter.php` (+63 -0) ➕ `Classes/Filters/OldThreeFilter.php` (+72 -0) _...and 26 more files_ </details> ### 📄 Description Split up and re-factor the image filters. Each filter is it's own class, inheriting from an AbstractFilter, and FilterInterface. Filters are created using a new FilterFactory. This PR also introduces the namespace auto loader. Breaking changes: PHP 7.0 required (type hints, strict types) Functionality changes: none Recommend a full test of all filters before merging. (This PR is branched from the PSR2 work - merge that one first). Linking #57 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>