[PR #58] [CLOSED] CS fixer, PSR2. #147

New issue

Closed

opened 2026-02-25 23:40:55 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:40:55 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/HaschekSolutions/pictshare/pull/58
Author: @birkett
Created: 6/21/2018
Status: ❌ Closed

Base: master ← Head: psr2

📝 Commits (1)

7ea14ce CS fixer, PSR2.

📊 Changes

20 files changed (+2639 additions, -2529 deletions)

View changed files

📝 backend.php (+55 -54)
📝 classes/backblaze.php (+105 -91)
📝 classes/filter.php (+214 -216)
📝 classes/html.php (+47 -40)
📝 classes/image.php (+269 -215)
📝 classes/model.php (+16 -23)
📝 cli.php (+18 -13)
📝 inc/core.php (+477 -502)
📝 inc/example.config.inc.php (+89 -89)
📝 index.php (+17 -12)
📝 models/pictsharemodel.php (+1047 -1012)
📝 template.php (+56 -56)
📝 template_album.php (+14 -13)
📝 template_album_embed.php (+14 -13)
📝 template_mp4.php (+17 -15)
📝 tools/backblaze_upload.php (+44 -41)
📝 tools/cleanup.php (+47 -39)
📝 tools/re-encode_mp4.php (+34 -31)
📝 tools/recreate_hashlist.php (+14 -10)
📝 tools/render_webm_ogg.php (+45 -44)

📄 Description

This commit is the result of running cs-fixer / CodeSniffer over the code.
This is close to PSR1 + PSR2 compliant - the remaining issues are:

Files are defining classes / methods, and running code with effects. They should do one or the other, not both.
Some very long lines of code.

These will be fixed with refactoring, to follow.

Breaking changes: none
Functionality changes: none

I recommend a quick test of all functionality before merging this, just in case something changed.

Linking to #57

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/HaschekSolutions/pictshare/pull/58 **Author:** [@birkett](https://github.com/birkett) **Created:** 6/21/2018 **Status:** ❌ Closed **Base:** `master` ← **Head:** `psr2` --- ### 📝 Commits (1) - [`7ea14ce`](https://github.com/HaschekSolutions/pictshare/commit/7ea14ce486f4309e2f28658705dff6f079652d24) CS fixer, PSR2. ### 📊 Changes **20 files changed** (+2639 additions, -2529 deletions) <details> <summary>View changed files</summary> 📝 `backend.php` (+55 -54) 📝 `classes/backblaze.php` (+105 -91) 📝 `classes/filter.php` (+214 -216) 📝 `classes/html.php` (+47 -40) 📝 `classes/image.php` (+269 -215) 📝 `classes/model.php` (+16 -23) 📝 `cli.php` (+18 -13) 📝 `inc/core.php` (+477 -502) 📝 `inc/example.config.inc.php` (+89 -89) 📝 `index.php` (+17 -12) 📝 `models/pictsharemodel.php` (+1047 -1012) 📝 `template.php` (+56 -56) 📝 `template_album.php` (+14 -13) 📝 `template_album_embed.php` (+14 -13) 📝 `template_mp4.php` (+17 -15) 📝 `tools/backblaze_upload.php` (+44 -41) 📝 `tools/cleanup.php` (+47 -39) 📝 `tools/re-encode_mp4.php` (+34 -31) 📝 `tools/recreate_hashlist.php` (+14 -10) 📝 `tools/render_webm_ogg.php` (+45 -44) </details> ### 📄 Description This commit is the result of running cs-fixer / CodeSniffer over the code. This is close to PSR1 + PSR2 compliant - the remaining issues are: - Files are defining classes / methods, and running code with effects. They should do one or the other, not both. - Some very long lines of code. These will be fixed with refactoring, to follow. Breaking changes: none Functionality changes: none I recommend a quick test of all functionality before merging this, just in case something changed. Linking to #57 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>