[PR #48] [MERGED] Fix MASTER_DELETE_CODE to work with deletion codes with uppercase letters #145

New issue

Closed

opened 2026-02-25 23:40:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 23:40:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/HaschekSolutions/pictshare/pull/48
Author: @evaera
Created: 3/19/2018
Status: ✅ Merged
Merged: 3/22/2018
Merged by: @geek-at

Base: master ← Head: master

📝 Commits (1)

6d015c6 Convert MASTER_DELETE_CODE to lowercase

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 models/pictsharemodel.php (+2 -2)

📄 Description

Hello,

After about an hour of trying to figure out why my master delete code wasn't working, I discovered that the problem was that my master deletion code had uppercase characters. Deletion codes with uppercase characters are always rejected because each URL segment is converted to lowercase before being compared. My temporary solution was to just convert my code to lowercase.

The changes made in this PR will ensure that the MASTER_DELETE_CODE is converted to lowercase in the comparison, which will allow codes with uppercase letters to work.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/HaschekSolutions/pictshare/pull/48 **Author:** [@evaera](https://github.com/evaera) **Created:** 3/19/2018 **Status:** ✅ Merged **Merged:** 3/22/2018 **Merged by:** [@geek-at](https://github.com/geek-at) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`6d015c6`](https://github.com/HaschekSolutions/pictshare/commit/6d015c63924b7e00f07745f9c8b2a42a4355c3f3) Convert MASTER_DELETE_CODE to lowercase ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `models/pictsharemodel.php` (+2 -2) </details> ### 📄 Description Hello, After about an hour of trying to figure out why my master delete code wasn't working, I discovered that the problem was that my master deletion code had uppercase characters. Deletion codes with uppercase characters are always rejected because each URL segment is [converted to lowercase](https://github.com/chrisiaut/pictshare/blob/master/models/pictsharemodel.php#L70) before being compared. My temporary solution was to just convert my code to lowercase. The changes made in this PR will ensure that the MASTER_DELETE_CODE is converted to lowercase in the comparison, which will allow codes with uppercase letters to work. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>