mirror of
https://github.com/photoprism/photoprism-docs.git
synced 2026-04-25 02:35:50 +03:00
[GH-ISSUE #161] Mkdocs: Links without trailing / can break sidebar navigation #33
Labels
No labels
bug
docs 📚
done
enhancement
enhancement
help wanted
idea
low-priority
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/photoprism-docs#33
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @strugee on GitHub (Sep 18, 2023).
Original GitHub issue: https://github.com/photoprism/photoprism-docs/issues/161
Originally assigned to: @lastzero on GitHub.
STR:
github.com/photoprism/photoprism@e737083822/CONTRIBUTING.md (submitting-pull-requests)Adding a
/to the URL - e.g. https://docs.photoprism.app/developer-guide/pull-requests/ - makes the sidebar function as intended.@lastzero commented on GitHub (Sep 18, 2023):
Maybe that's something that must be fixed in mkdocs material then?
Edit: I've asked for advice in their private support chat. Maybe this can be solved with a config option. The site is hosed on a CDN, so we don't directly control the web server config.
@lastzero commented on GitHub (Sep 18, 2023):
It seems that this needs to be fixed on the server side or in the CDN config. So I'll have to postpone finding a solution until I have time for doing this.
@strugee commented on GitHub (Sep 18, 2023):
Another option is to do it the quick and dirty way and add a bit of JavaScript to fix up the URL. Doing it server side is better though since that obviously won't work for anyone with JavaScript disabled.
@lastzero commented on GitHub (May 9, 2024):
I've tested this again and the problem seems to be fixed with the latest version of MkDocs Material, which we use to render our docs from Markdown files. Shall we close this issue then?
@strugee commented on GitHub (May 9, 2024):
Hmm. I can still reproduce using the STR from the description?
@lastzero commented on GitHub (May 9, 2024):
You're right, my bad. Didn't properly follow the steps!
@strugee commented on GitHub (May 9, 2024):
No problem!
@graciousgrey commented on GitHub (Jan 24, 2025):
This seems to work now. I tested with the exact steps mentioned above and the missing slash has been added automatically.
@lastzero commented on GitHub (Jan 24, 2025):
Since we moved our docs from DigitalOcean to our own server and CDN, this issue seems to be resolved. Feel free to test again!