mirror of
https://github.com/photoprism/photoprism-docs.git
synced 2026-04-25 02:35:50 +03:00
[GH-ISSUE #28] Replace images hosted on Twitter #11
Labels
No labels
bug
docs 📚
done
enhancement
enhancement
help wanted
idea
low-priority
pull-request
question
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/photoprism-docs#11
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alexislefebvre on GitHub (Nov 20, 2020).
Original GitHub issue: https://github.com/photoprism/photoprism-docs/issues/28
Some images are provided by Twitter: https://github.com/photoprism/photoprism-docs/search?q=twimg
These images are blocked by Firefox when using the Strict Enhanced Tracking Protection from Firefox.
So instead of images, we see white rectangle or nothing.
These images should be hosted elsewhere. Ideally on the same server than the doc to avoid depending on an external resource.
Example on https://docs.photoprism.org/developer-guide/metadata/classification/ :
@lastzero commented on GitHub (Nov 22, 2020):
True. Only affects the developer guide though?
@alexislefebvre commented on GitHub (Nov 22, 2020):
This page is affected too: https://docs.photoprism.org/user-guide/settings/library/
@graciousgrey commented on GitHub (Nov 23, 2020):
Should be fixed now, let me know in case I forgot one.
@alexislefebvre commented on GitHub (Nov 24, 2020):
It looks like it's not deployed as for now.
@graciousgrey commented on GitHub (Nov 24, 2020):
True, I forgot to deploy - now it is ;)
@alexislefebvre commented on GitHub (Nov 24, 2020):
Nice, I can see images now. Thanks!