[PR #29] [MERGED] Feat/timezone bound displays #144

Closed
opened 2026-02-26 21:34:39 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/eduardolat/pgbackweb/pull/29
Author: @julien-wff
Created: 8/13/2024
Status: Merged
Merged: 8/15/2024
Merged by: @eduardolat

Base: mainHead: Feat/timezone-bound-display


📝 Commits (1)

  • 07af002 Add .Local() to all time formatting to reflect server timezone

📊 Changes

8 files changed (+13 additions, -13 deletions)

View changed files

📝 internal/view/web/dashboard/backups/list_backups.go (+1 -1)
📝 internal/view/web/dashboard/databases/list_databases.go (+1 -1)
📝 internal/view/web/dashboard/destinations/list_destinations.go (+1 -1)
📝 internal/view/web/dashboard/executions/list_executions.go (+2 -2)
📝 internal/view/web/dashboard/executions/show_execution.go (+3 -3)
📝 internal/view/web/dashboard/profile/close_all_sessions.go (+1 -1)
📝 internal/view/web/dashboard/restorations/list_restorations.go (+2 -2)
📝 internal/view/web/dashboard/restorations/show_restoration.go (+2 -2)

📄 Description

Hi there!

As mentioned in #25, time is always UTC throughout the app. I think it would be better off following the timezone of the container, so I added .Local() to every time formatting.

Maybe following the browser's time would be even better, but using SSR makes it more complicated to implement. I think for now it's fine.

Hope you agree!


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/eduardolat/pgbackweb/pull/29 **Author:** [@julien-wff](https://github.com/julien-wff) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/15/2024 **Merged by:** [@eduardolat](https://github.com/eduardolat) **Base:** `main` ← **Head:** `Feat/timezone-bound-display` --- ### 📝 Commits (1) - [`07af002`](https://github.com/eduardolat/pgbackweb/commit/07af002c4aa5d3b79ba2829166dfda2f788ef98b) Add `.Local()` to all time formatting to reflect server timezone ### 📊 Changes **8 files changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `internal/view/web/dashboard/backups/list_backups.go` (+1 -1) 📝 `internal/view/web/dashboard/databases/list_databases.go` (+1 -1) 📝 `internal/view/web/dashboard/destinations/list_destinations.go` (+1 -1) 📝 `internal/view/web/dashboard/executions/list_executions.go` (+2 -2) 📝 `internal/view/web/dashboard/executions/show_execution.go` (+3 -3) 📝 `internal/view/web/dashboard/profile/close_all_sessions.go` (+1 -1) 📝 `internal/view/web/dashboard/restorations/list_restorations.go` (+2 -2) 📝 `internal/view/web/dashboard/restorations/show_restoration.go` (+2 -2) </details> ### 📄 Description Hi there! As mentioned in #25, time is always UTC throughout the app. I think it would be better off following the timezone of the container, so I added `.Local()` to every time formatting. Maybe following the browser's time would be even better, but using SSR makes it more complicated to implement. I think for now it's fine. Hope you agree! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 21:34:39 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/pgbackweb#144
No description provided.