mirror of
https://github.com/eduardolat/pgbackweb.git
synced 2026-04-25 13:45:54 +03:00
[PR #29] [MERGED] Feat/timezone bound displays #144
Labels
No labels
bug
confirmed next step
duplicate
enhancement
help wanted
in progress
in progress
pull-request
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/pgbackweb#144
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/eduardolat/pgbackweb/pull/29
Author: @julien-wff
Created: 8/13/2024
Status: ✅ Merged
Merged: 8/15/2024
Merged by: @eduardolat
Base:
main← Head:Feat/timezone-bound-display📝 Commits (1)
07af002Add.Local()to all time formatting to reflect server timezone📊 Changes
8 files changed (+13 additions, -13 deletions)
View changed files
📝
internal/view/web/dashboard/backups/list_backups.go(+1 -1)📝
internal/view/web/dashboard/databases/list_databases.go(+1 -1)📝
internal/view/web/dashboard/destinations/list_destinations.go(+1 -1)📝
internal/view/web/dashboard/executions/list_executions.go(+2 -2)📝
internal/view/web/dashboard/executions/show_execution.go(+3 -3)📝
internal/view/web/dashboard/profile/close_all_sessions.go(+1 -1)📝
internal/view/web/dashboard/restorations/list_restorations.go(+2 -2)📝
internal/view/web/dashboard/restorations/show_restoration.go(+2 -2)📄 Description
Hi there!
As mentioned in #25, time is always UTC throughout the app. I think it would be better off following the timezone of the container, so I added
.Local()to every time formatting.Maybe following the browser's time would be even better, but using SSR makes it more complicated to implement. I think for now it's fine.
Hope you agree!
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.