[PR #31] [MERGED] feat: Add version metric #41

New issue

Closed

opened 2026-03-03 16:27:54 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:27:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/natrontech/pbs-exporter/pull/31
Author: @lcaflc
Created: 6/25/2024
Status: ✅ Merged
Merged: 6/25/2024
Merged by: @janfuhrer

Base: main ← Head: main

📝 Commits (3)

528c561 feat: Add version metric
5ac4f6c feat: Add repoid and release to version metric
23a5ff8 chore: Add version metric to README

📊 Changes

2 files changed (+79 additions, -1 deletions)

View changed files

📝 README.md (+1 -0)
📝 main.go (+78 -1)

📄 Description

What this PR does:

Add support for version metrics retrieved from PBS API.

Notes for Reviewer:

We have to set the version as a label because this is not a "metric". This mimic what is done with the pve_exporter https://github.com/prometheus-pve/prometheus-pve-exporter

Checklist:

I have read and understood the CONTRIBUTING and CODE_OF_CONDUCT documents
Pull Request title in the format of Conventional Commits e.g. feat|fix|chore|docs|...: Changed Something
Updated documentation in the README.md file (e.g. new parameters, environment variables, return values, ...)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/natrontech/pbs-exporter/pull/31 **Author:** [@lcaflc](https://github.com/lcaflc) **Created:** 6/25/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@janfuhrer](https://github.com/janfuhrer) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`528c561`](https://github.com/natrontech/pbs-exporter/commit/528c5612e330fbfb34bc546e734f0f0a0599f104) feat: Add version metric - [`5ac4f6c`](https://github.com/natrontech/pbs-exporter/commit/5ac4f6c5e83cf94e63bc4db02ad1f2cdf366b87c) feat: Add repoid and release to version metric - [`23a5ff8`](https://github.com/natrontech/pbs-exporter/commit/23a5ff84385badee7f09cdc16865098826d54df2) chore: Add version metric to README ### 📊 Changes **2 files changed** (+79 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `main.go` (+78 -1) </details> ### 📄 Description  **What this PR does**: Add support for version metrics retrieved from PBS API. **Notes for Reviewer**: We have to set the version as a label because this is not a "metric". This mimic what is done with the pve_exporter <https://github.com/prometheus-pve/prometheus-pve-exporter> **Checklist**: - [x] I have read and understood the [CONTRIBUTING](https://github.com/natrontech/pbs-exporter/blob/main/CONTRIBUTING.md) and [CODE_OF_CONDUCT](https://github.com/natrontech/pbs-exporter/blob/main/CODE_OF_CONDUCT.md) documents - [x] Pull Request title in the format of [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) e.g. `feat|fix|chore|docs|...: Changed Something` - [x] Updated documentation in the `README.md` file (e.g. new parameters, environment variables, return values, ...) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>