[PR #18] [MERGED] allow empty string ("") namespace #30

New issue

Closed

opened 2026-03-03 16:27:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-03 16:27:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/natrontech/pbs-exporter/pull/18
Author: @nalabelle
Created: 5/4/2024
Status: ✅ Merged
Merged: 5/24/2024
Merged by: @janfuhrer

Base: main ← Head: patch-1

📝 Commits (1)

b05451e allow empty string ("") namespace

📊 Changes

1 file changed (+0 additions, -5 deletions)

View changed files

📝 main.go (+0 -5)

📄 Description

I never set a namespace, so I'm thinking "" is the default. My /admin/datastore/{store}/namespace returns {"data":[{"ns":""}]}. After removing this skip, I can see pbs_snapshot_* stats.

Thanks for putting this project up!

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/natrontech/pbs-exporter/pull/18 **Author:** [@nalabelle](https://github.com/nalabelle) **Created:** 5/4/2024 **Status:** ✅ Merged **Merged:** 5/24/2024 **Merged by:** [@janfuhrer](https://github.com/janfuhrer) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`b05451e`](https://github.com/natrontech/pbs-exporter/commit/b05451e65029747d6f38c4ed1936fe02b6d286e0) allow empty string ("") namespace ### 📊 Changes **1 file changed** (+0 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `main.go` (+0 -5) </details> ### 📄 Description I never set a namespace, so I'm thinking "" is the default. My `/admin/datastore/{store}/namespace` returns `{"data":[{"ns":""}]}`. After removing this skip, I can see `pbs_snapshot_*` stats. Thanks for putting this project up! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>