mirror of
https://github.com/ciur/papermerge.git
synced 2026-04-25 12:05:58 +03:00
[GH-ISSUE #59] How to stop integrated worker #44
Labels
No labels
2.1
3.0
3.0.1
3.0.2
3.0.3
3.0.3
3.1
3.2
3.2
3.3
3.5
3.x
Fixed. Waiting for feedback.
Fixed. Waiting for feedback.
UX
Version 2.1 - alpha
XSS
announcement
beta
blocker
bug
cannot reproduce
confirmed
confirmed
critical
demo
dependencies
deployment
detchnical debt
discussion
docker
documentation
donations
duplicate
enhancement
feature request
frontend
fundraising
good first issue
good issue
help wanted
high
implemented
important
improvement
incomplete
invalid
investigation
kubernetes
low
low impact
medium
medium
medium impact
migration from 2.0
migration from 2.1
missing-language
missing-ocr-language
no-activity
note
ocr
outofscope
packaging
performance
popular request
pull-request
pypi
question
raspberry pi
roadmap
search
security
setup
status
task
technical debt
updates
user xp
version 1.4.0 - demo
will be implemented
will not be implemented
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/papermerge#44
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mtonnie on GitHub (Aug 8, 2020).
Original GitHub issue: https://github.com/ciur/papermerge/issues/59
When I start the worker from manage.py worker and detach the process I'm not able to stop the worker.
There is no stop command and no possibility to write a pid file for the worker process.
I'm facing this issue when I try to create the start/stop mechanism for Synolog package #31 .
I have made a quick an dirty patch to pass the pidfile attributte, but I guess there are other more smarter solution.
Baybe to implement a worker start / workerr stop feature or to implement the pidfile as an optional command line argument.
001-worker_pidfile.txt
What's the prefered solution?
@ciur commented on GitHub (Aug 8, 2020):
Good one ! Very well formulated issue 👍
start/stop commands should be part of external process management service like SystemD.
I would go with last option - pass optional pid file path as argument - if that works for you, for me it would be fine as well.
I would gladly accept your PR with that change. With only humble remark - argument should be optional.
Thank you ! Danke Danke!