mirror of
https://github.com/ciur/papermerge.git
synced 2026-04-25 12:05:58 +03:00
[GH-ISSUE #397] Use Ctrl Modifier to Select Files #310
Labels
No labels
2.1
3.0
3.0.1
3.0.2
3.0.3
3.0.3
3.1
3.2
3.2
3.3
3.5
3.x
Fixed. Waiting for feedback.
Fixed. Waiting for feedback.
UX
Version 2.1 - alpha
XSS
announcement
beta
blocker
bug
cannot reproduce
confirmed
confirmed
critical
demo
dependencies
deployment
detchnical debt
discussion
docker
documentation
donations
duplicate
enhancement
feature request
frontend
fundraising
good first issue
good issue
help wanted
high
implemented
important
improvement
incomplete
invalid
investigation
kubernetes
low
low impact
medium
medium
medium impact
migration from 2.0
migration from 2.1
missing-language
missing-ocr-language
no-activity
note
ocr
outofscope
packaging
performance
popular request
pull-request
pypi
question
raspberry pi
roadmap
search
security
setup
status
task
technical debt
updates
user xp
version 1.4.0 - demo
will be implemented
will not be implemented
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/papermerge#310
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Ionshard on GitHub (Jul 4, 2021).
Original GitHub issue: https://github.com/ciur/papermerge/issues/397
Originally assigned to: @ciur on GitHub.
Currently to select files in Papermerge you either need to select the checkbox on a file or use the rectangle selection. This can make it difficult to select many files that are not all in the same location.
When using a file editor in any major OS they support using the Control key as a way to add to the selection.
Thus with Papermerge I think it would be nice if it supported this as well. If I hold down the control key and click a document, rather than navigating to the document itself it would be nice to just select the document instead.
I understand that on the web that Ctrl+Click can also mean to open up in a new tab. However testing on my local papermerge installation it appears that Ctrl+Click doesn't currently open a new tab. So this request wouldn't change any existing behavior with the application.
@Ionshard commented on GitHub (Jul 4, 2021):
Putting on my developer hat for a minute. I think this might be pretty easy to do. Maybe I'll try to get the code running locally and see if I can help out if this is an acceptable solution.
Looking at the papermerge JS code. In the browse.js view you already have a really useful
select_node_by_cidthat you call when the checkbox is clicked and in the on_node_clicked_handler you are getting the cid to open the node anyways.Looks like it should be possible to grab the state of the Control Key from the mouse event and just call the
select_node_by_cidfunction instead.Looks like there may be some additional handling to handle the UI updates that are in the
on_checkbox_clickedthat would need to be refactored.If I am not crazy and missing something obvious and you are open to contributions let me know and I can give it a shot. Otherwise you probably don't need the help to do it yourself and can ignore everything I said above 😝
@ciur commented on GitHub (Jul 5, 2021):
@Ionshard, yes, indeed, it is not that hard to add. However, please note that I am refactoring most of the code out of papermerge JS into smaller npm packages. The part responsible for selection is now in commander-js.