mirror of
https://github.com/ciur/papermerge.git
synced 2026-04-25 12:05:58 +03:00
[GH-ISSUE #245] Have all configs in one place or read from admin-made drop-in config files #197
Labels
No labels
2.1
3.0
3.0.1
3.0.2
3.0.3
3.0.3
3.1
3.2
3.2
3.3
3.5
3.x
Fixed. Waiting for feedback.
Fixed. Waiting for feedback.
UX
Version 2.1 - alpha
XSS
announcement
beta
blocker
bug
cannot reproduce
confirmed
confirmed
critical
demo
dependencies
deployment
detchnical debt
discussion
docker
documentation
donations
duplicate
enhancement
feature request
frontend
fundraising
good first issue
good issue
help wanted
high
implemented
important
improvement
incomplete
invalid
investigation
kubernetes
low
low impact
medium
medium
medium impact
migration from 2.0
migration from 2.1
missing-language
missing-ocr-language
no-activity
note
ocr
outofscope
packaging
performance
popular request
pull-request
pypi
question
raspberry pi
roadmap
search
security
setup
status
task
technical debt
updates
user xp
version 1.4.0 - demo
will be implemented
will not be implemented
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/papermerge#197
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @amo13 on GitHub (Dec 5, 2020).
Original GitHub issue: https://github.com/ciur/papermerge/issues/245
Originally assigned to: @ciur on GitHub.
Is your feature request related to a problem? Please describe.
I set up redis as a message broker and the configuration for this is in base.py. Upon updates, this files gets overwritten by the updated file, which is good from the update point on view, but inconvenient from the config point of view.
Describe the solution you'd like
Move the configuration part for redis (and maybe other potentially relevant configurations) from base.py to papermerge.conf.py, which does not get overwritten. Another idea would be to have a folder from which drop-in configuration files are read, maybe with lower precedence than the main config file papermerge.conf.py.
@ciur commented on GitHub (Mar 8, 2021):
@amo13, in base.py only general purpose configuration goes. Think of base.py as a place which gathers all config from other, more specific places.
Those "specific" places are two:
Configuration are assembled in base.py file which imports all configurations from production.py (or dev.py or whatever DJANGO_SETTINGS_MODULE points to) AND from papermerge.conf.py.
Here is more info on the topic.
I am pretty happy how configuration works now. It is practical and generally speaking no objection about its structure.