mirror of
https://github.com/ConvoyPanel/panel.git
synced 2026-04-25 04:35:52 +03:00
[GH-ISSUE #121] Add error checking before creation and deletion #80
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/panel#80
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @AnushK-Fro on GitHub (Nov 10, 2024).
Original GitHub issue: https://github.com/ConvoyPanel/panel/issues/121
Is there an existing feature request for this?
Describe the feature you would like to see.
The current approach in Convoy fires off a job to create and delete a virtual machine. This has the advantage of speeding up the creation and deletion process. However, if a deployment fails, then it is not possible for an application such as WHMCS or Blesta to find out about it unless they are polling Convoy and constantly checking the status. For example, if a host node is down and Convoy tries deploying a VM on it, that VM will be fail to install but WHMCS would mark it as provisioned since Convoy returns no error through the API.
Describe the solution you'd like.
Convoy should run tests to make sure that the virtual machine can deploy before deploying the machine. If it detects that it cannot deploy a virtual machine for some reason (i.e., node is offline, template is not on the destination node, etc), then it should not. It may not even be necessary to fire off the creation or deletion process as a job.
Additional context to this request.
No response
@ericwang401 commented on GitHub (Nov 10, 2024):
Is it possible for Convoy to fire webhook requests alternatively? This would be similar to how Stripe sends webhook requests to notify applications of completed transactions.
This approach would be better because it would notify WHMCS of errors that occurred during the process-even if the checks you’ve proposed passed (false negative).