mirror of
https://github.com/ConvoyPanel/panel.git
synced 2026-04-25 12:45:54 +03:00
[GH-ISSUE #48] Error Reading Undefined Size Attribute on Disks #31
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/panel#31
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ericwang401 on GitHub (Nov 3, 2023).
Original GitHub issue: https://github.com/ConvoyPanel/panel/issues/48
Background
In Proxmox, disks can be mounted without any media attached, and this results in a disk without any "size" attribute. For example, you can mount an IDE CD/DVD drive without any media and that would have no size attribute.
By default, Convoy assumes every disk has a size attribute. This works for Convoy's official images, but can be problematic for users' custom images if they aren't aware of this bug.
Proposed fix
Give disks without the size attribute a default size of 0.
@ericwang401 commented on GitHub (Nov 11, 2023):
Resolved in
9cb2cf0da0.Will be pushed in v4 release.