[PR #127] [CLOSED] Fix realm bug in PruneUsersJob #124

Closed
opened 2026-02-26 17:31:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ConvoyPanel/panel/pull/127
Author: @GunniBusch
Created: 12/30/2024
Status: Closed

Base: developHead: fix-realm-bug


📝 Commits (1)

  • f2a8591 Fix realm bug in PruneUsersJob

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 app/Repositories/Proxmox/Node/ProxmoxAccessRepository.php (+10 -1)

📄 Description

Fixes #126

Filter users by realm type before converting them into UserData in the getUsers method in app/Repositories/Proxmox/Node/ProxmoxAccessRepository.php.

  • Add a check to see if the realm type can be casted to the RealmType enum before creating a UserData object.
  • Ignore users with realm types different than those in the enum.

For more details, open the Copilot Workspace session.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ConvoyPanel/panel/pull/127 **Author:** [@GunniBusch](https://github.com/GunniBusch) **Created:** 12/30/2024 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `fix-realm-bug` --- ### 📝 Commits (1) - [`f2a8591`](https://github.com/ConvoyPanel/panel/commit/f2a8591398bb6e985c7215423a748c5f8b9784df) Fix realm bug in PruneUsersJob ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/Repositories/Proxmox/Node/ProxmoxAccessRepository.php` (+10 -1) </details> ### 📄 Description Fixes #126 Filter users by realm type before converting them into UserData in the `getUsers` method in `app/Repositories/Proxmox/Node/ProxmoxAccessRepository.php`. * Add a check to see if the realm type can be casted to the `RealmType` enum before creating a `UserData` object. * Ignore users with realm types different than those in the enum. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ConvoyPanel/panel/pull/127?shareId=c15d812c-0664-4559-b747-338a3b48a1ec). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 17:31:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/panel#124
No description provided.