mirror of
https://github.com/aluxnimm/outlookcaldavsynchronizer.git
synced 2026-04-25 11:05:56 +03:00
[GH-ISSUE #215] Default proxy settings are not updated on system proxy settings change #676
Labels
No labels
1.0
1.0
1.0
2.0
Feature
Feature request
Google
Google Calendar
async
attachement
auto-migrated
auto-migrated
auto-migrated
bug
critical
enhancement
help wanted
implemented
pull-request
solved
solved
sourceforge
sourceforge
sourceforge
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/outlookcaldavsynchronizer#676
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @abukhnin on GitHub (Nov 27, 2017).
Original GitHub issue: https://github.com/aluxnimm/outlookcaldavsynchronizer/issues/215
A synchronization issue occurs when the system proxy settings change.
Reproduced with Outlook CalDav Synchronizer 2.26.0.0, Outlook 2013 on Windows 8.1.
To reporoduce:
log.txt
Restarting Outlook fixes the issue until the next system proxy settings change.
Here is a patch that helps me prevent the issue:
dynamic_proxy_patch.txt
@aluxnimm commented on GitHub (Nov 29, 2017):
Thank you, we will look into it.
@aluxnimm commented on GitHub (Dec 5, 2018):
Your patch has not the same behaviour. DefaultWebProxy read settings from app.config and as fallback from Windows settings but GetSystemWebProxy() doesn't consider app.config.
@abukhnin commented on GitHub (Dec 9, 2018):
I see. I tested my patch with DefaultWebProxy instead of GetSystemWebProxy(), but it didn't work - the proxy wasn't properly set upon connection to a corporate network. I suppose that's because DefaultWebProxy is only set once on application start.
In a comment at https://stackoverflow.com/questions/14887679/whats-the-difference-between-webrequest-defaultwebproxy-and-webrequest-getsyste#comment20889389_14888220 it is suggested to use DefaultWebProxy for "custom proxy configuration" and GetSystemWebProxy() for "use system settings" option.
Maybe indeed these should be separate options along with "use manual proxy configuration"?
@aluxnimm commented on GitHub (Dec 9, 2018):
Would be rather confusing to have two different default options, question is if anybody uses app.config settings.
@abukhnin commented on GitHub (Dec 9, 2018):
Maybe, name them something like "Static default proxy configuration" and "Dynamic system proxy configuration"?
Besides backward compatibility for those who did use app.config, one more reason to have both these options is to let users prevent delays in particular cases, like this one: https://developercommunity.visualstudio.com/content/problem/108772/webrequestgetsystemwebproxy-occasionally-very-slow.html
I know that extra customization options may indicate unresolved design problems, but here they seem to be justified.