mirror of
https://github.com/aluxnimm/outlookcaldavsynchronizer.git
synced 2026-04-27 03:45:59 +03:00
[GH-ISSUE #182] iCloud CardDAV vcf file injecting crlf on photo URL causing a 401 error in logs #647
Labels
No labels
1.0
1.0
1.0
2.0
Feature
Feature request
Google
Google Calendar
async
attachement
auto-migrated
auto-migrated
auto-migrated
bug
critical
enhancement
help wanted
implemented
pull-request
solved
solved
sourceforge
sourceforge
sourceforge
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/outlookcaldavsynchronizer#647
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @iamGavinJ on GitHub (Dec 7, 2016).
Original GitHub issue: https://github.com/aluxnimm/outlookcaldavsynchronizer/issues/182
Contact photos aren't being downloaded from iCloud because the vcf file returned has a carriage-return/line-feed in the photo URL after
/WBS.e.g.
PHOTO;TYPE=JPEG;VALUE=uri:https://p02-contacts.icloud.com:443/<MY ID>/wbs /015d400012d0217002d3372af883ca28f0014f5851The mapping warning report show the following .NET exception
Could not add picture for contact. : System.Net.WebException: The remote server returned an error: (401) Unauthorized. at System.Net.HttpWebRequest.EndGetResponse(IAsyncResult asyncResult) at System.Net.WebClient.GetWebResponse(WebRequest request, IAsyncResult result) at System.Net.WebClient.DownloadBitsResponseCallback(IAsyncResult result) --- End of stack trace from previous location where exception was thrown --- at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task) at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task) at CalDavSynchronizer.Implementation.Contacts.ContactEntityMapper.<MapPhoto2To1>d__20.MoveNext()@aluxnimm commented on GitHub (Dec 7, 2016):
Never tested iCloud with contact photos.
The problem is not the cr/lf in the photo attribute but the missing authentication.
When trying the url in the browser, it complains about missing
X-APPLE-WEBAUTH-TOKEN
We would need to fetch that somehow especially for icloud similar to
https://codedump.io/share/OGoCdrXWqeKu/1/get-icloud-contact-list-in-c
@iamGavinJ commented on GitHub (Dec 8, 2016):
Ah, it must have been using cached credentials/cookie because I pasted the link into a browser and it pulled back the image ok.
@VincentvgNn commented on GitHub (May 8, 2017):
Hi,
Even if you have no Apple devices you can easily setup a free iCloud account for testing.
I tried the OpenProtocols Connector with iCloud and that works fine for syncing pictures. Unfortunately I could not get that connector working for fruux and the menu is by far not that versatile.
It would be an advantage if the Outlook CalDav Synchronizer could manage picture links from iCloud and that the iCloud logo could be added to the optional synchronization profiles.
@aluxnimm commented on GitHub (Sep 12, 2017):
Support for iCloud contact profiles with working picture sync and even sync of Outlook distribution lists to iCloud contact groups implemented in 2.24.0.
@iamGavinJ commented on GitHub (Sep 13, 2017):
@aluxnimm works fantastically!!! Thank you so much. Awesome work.
@arpena commented on GitHub (Sep 20, 2017):
Doesn't work for me. There is some preference that I have to change?
@aluxnimm commented on GitHub (Sep 20, 2017):
Yes this is disabled by default. Advanced settings, contact mapping configuration, enable "Map Distribution lists" and choose iCloud groups for DAV contact groups format.