[PR #321] [CLOSED] Update ContactEntityMapper.cs #461

New issue

Closed

opened 2026-02-25 20:31:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-25 20:31:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/aluxnimm/outlookcaldavsynchronizer/pull/321
Author: @filippobottega
Created: 7/24/2021
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

36a1f18 Update ContactEntityMapper.cs

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 CalDavSynchronizer/Implementation/Contacts/ContactEntityMapper.cs (+1 -3)

📄 Description

I propose to delete lines:

...
if (string.IsNullOrEmpty (target.Inner.FullName))
target.Inner.FullName = source.FormattedName;
...

to let the possibility to create a contact without a name. For example a contact of a company with only an url and a phone number.
Now when I sync the contact with Radicale if the name is missing the FN value is used to set the FullName and the FormattedName is used to fill the FullName but I need the FullName remain empty.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/aluxnimm/outlookcaldavsynchronizer/pull/321 **Author:** [@filippobottega](https://github.com/filippobottega) **Created:** 7/24/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`36a1f18`](https://github.com/aluxnimm/outlookcaldavsynchronizer/commit/36a1f180b1ecc85469eb97e50d20d08a0f5a973e) Update ContactEntityMapper.cs ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `CalDavSynchronizer/Implementation/Contacts/ContactEntityMapper.cs` (+1 -3) </details> ### 📄 Description I propose to delete lines: ... if (string.IsNullOrEmpty (target.Inner.FullName)) target.Inner.FullName = source.FormattedName; ... to let the possibility to create a contact without a name. For example a contact of a company with only an url and a phone number. Now when I sync the contact with Radicale if the name is missing the FN value is used to set the FullName and the FormattedName is used to fill the FullName but I need the FullName remain empty. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>