[GH-ISSUE #40] Plaintext PIN/password #22

Open
opened 2026-02-25 22:30:47 +03:00 by kerem · 3 comments
Owner

Originally created by @wrossmann on GitHub (Mar 26, 2021).
Original GitHub issue: https://github.com/evgeny-gridasov/openvpn-otp/issues/40

It's a bit disappointing to see plaintext password storage in 2021, eg:

alice otp totp:sha1:base32:46HV5FIYE33TKWYP:5uP3rH4x0r:xxx *

It should be relatively simple to shim in crypt-compatible hashing, eg:

alice otp totp:sha1:base32:46HV5FIYE33TKWYP:$2y$10$HM6II7ESXVFq1XaylSa1R.8rNEhhlY4r74tRNFxIzWt94wyjJlDFW:xxx *
Originally created by @wrossmann on GitHub (Mar 26, 2021). Original GitHub issue: https://github.com/evgeny-gridasov/openvpn-otp/issues/40 It's a bit disappointing to see plaintext password storage in 2021, eg: ``` alice otp totp:sha1:base32:46HV5FIYE33TKWYP:5uP3rH4x0r:xxx * ``` It should be relatively simple to shim in crypt-compatible hashing, eg: ``` alice otp totp:sha1:base32:46HV5FIYE33TKWYP:$2y$10$HM6II7ESXVFq1XaylSa1R.8rNEhhlY4r74tRNFxIzWt94wyjJlDFW:xxx * ```
Author
Owner

@evgeny-gridasov commented on GitHub (Mar 27, 2021):

Yes I agree, that was on my todo list for quite a while. Perhaps I should do it.

<!-- gh-comment-id:808605402 --> @evgeny-gridasov commented on GitHub (Mar 27, 2021): Yes I agree, that was on my todo list for quite a while. Perhaps I should do it.
Author
Owner

@evgeny-gridasov commented on GitHub (Mar 27, 2021):

There is a pending PR, will review it some time during the week.

<!-- gh-comment-id:808605578 --> @evgeny-gridasov commented on GitHub (Mar 27, 2021): There is a pending PR, will review it some time during the week.
Author
Owner

@xcrezd commented on GitHub (Apr 8, 2021):

waiting for this feature too

<!-- gh-comment-id:815647945 --> @xcrezd commented on GitHub (Apr 8, 2021): waiting for this feature too
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/openvpn-otp#22
No description provided.