[PR #759] core: rename line/measure metadata #762

New issue

Open

opened 2026-03-02 23:48:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:48:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/759
Author: @simonklee
Created: 3/1/2026
Status: 🔄 Open

Base: fix-609 ← Head: layout-scan-rename

📝 Commits (2)

af14ba0 fix(core): make lineInfo.lineStarts byte-based across wrap modes
1f0c779 core: rename line/measure metadata

📊 Changes

24 files changed (+745 additions, -402 deletions)

View changed files

📝 packages/core/src/editor-view.ts (+1 -1)
📝 packages/core/src/renderables/Code.test.ts (+3 -3)
📝 packages/core/src/renderables/EditBufferRenderable.ts (+1 -1)
📝 packages/core/src/renderables/TextBufferRenderable.ts (+3 -3)
📝 packages/core/src/renderables/TextTable.ts (+1 -1)
📝 packages/core/src/renderables/__tests__/LineNumberRenderable.test.ts (+3 -3)
📝 packages/core/src/renderables/__tests__/Textarea.scroll.test.ts (+1 -1)
📝 packages/core/src/text-buffer-view.test.ts (+129 -61)
📝 packages/core/src/text-buffer-view.ts (+1 -1)
📝 packages/core/src/types.ts (+8 -3)
📝 packages/core/src/zig-structs.ts (+6 -6)
📝 packages/core/src/zig.ts (+41 -21)
📝 packages/core/src/zig/buffer.zig (+11 -11)
📝 packages/core/src/zig/editor-view.zig (+3 -3)
📝 packages/core/src/zig/lib.zig (+43 -43)
📝 packages/core/src/zig/tests/editor-view_test.zig (+2 -2)
📝 packages/core/src/zig/tests/text-buffer-drawing_test.zig (+6 -6)
📝 packages/core/src/zig/tests/text-buffer-iterators_test.zig (+9 -9)
📝 packages/core/src/zig/tests/text-buffer-view_test.zig (+231 -86)
📝 packages/core/src/zig/tests/text-buffer_test.zig (+3 -3)

...and 4 more files

📄 Description

Rename line and measure metadata fields. The old names mixed byte/column semantics, which have introduced some subtle bugs. This makes units explicit and moves qualifiers to suffix position so related names group naturally (for example, line_width_cols, line_width_cols_max).

Based it on #747 branch since that should be merged first.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/759 **Author:** [@simonklee](https://github.com/simonklee) **Created:** 3/1/2026 **Status:** 🔄 Open **Base:** `fix-609` ← **Head:** `layout-scan-rename` --- ### 📝 Commits (2) - [`af14ba0`](https://github.com/anomalyco/opentui/commit/af14ba0ea578e43f01fd7a43bb4a771f06b7500b) fix(core): make lineInfo.lineStarts byte-based across wrap modes - [`1f0c779`](https://github.com/anomalyco/opentui/commit/1f0c77921581fe3b3fbf8107211ff5059f71a7a2) core: rename line/measure metadata ### 📊 Changes **24 files changed** (+745 additions, -402 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/editor-view.ts` (+1 -1) 📝 `packages/core/src/renderables/Code.test.ts` (+3 -3) 📝 `packages/core/src/renderables/EditBufferRenderable.ts` (+1 -1) 📝 `packages/core/src/renderables/TextBufferRenderable.ts` (+3 -3) 📝 `packages/core/src/renderables/TextTable.ts` (+1 -1) 📝 `packages/core/src/renderables/__tests__/LineNumberRenderable.test.ts` (+3 -3) 📝 `packages/core/src/renderables/__tests__/Textarea.scroll.test.ts` (+1 -1) 📝 `packages/core/src/text-buffer-view.test.ts` (+129 -61) 📝 `packages/core/src/text-buffer-view.ts` (+1 -1) 📝 `packages/core/src/types.ts` (+8 -3) 📝 `packages/core/src/zig-structs.ts` (+6 -6) 📝 `packages/core/src/zig.ts` (+41 -21) 📝 `packages/core/src/zig/buffer.zig` (+11 -11) 📝 `packages/core/src/zig/editor-view.zig` (+3 -3) 📝 `packages/core/src/zig/lib.zig` (+43 -43) 📝 `packages/core/src/zig/tests/editor-view_test.zig` (+2 -2) 📝 `packages/core/src/zig/tests/text-buffer-drawing_test.zig` (+6 -6) 📝 `packages/core/src/zig/tests/text-buffer-iterators_test.zig` (+9 -9) 📝 `packages/core/src/zig/tests/text-buffer-view_test.zig` (+231 -86) 📝 `packages/core/src/zig/tests/text-buffer_test.zig` (+3 -3) _...and 4 more files_ </details> ### 📄 Description Rename line and measure metadata fields. The old names mixed byte/column semantics, which have introduced some subtle bugs. This makes units explicit and moves qualifiers to suffix position so related names group naturally (for example, line_width_cols, line_width_cols_max). Based it on [#747](https://github.com/anomalyco/opentui/pull/747) branch since that should be merged first. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>