[PR #695] [CLOSED] fix(markdown): only skip incomplete rows in streaming tables #720

New issue

Closed

opened 2026-03-02 23:47:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:47:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/695
Author: @remorses
Created: 2/16/2026
Status: ❌ Closed

Base: main ← Head: fix/markdown-streaming-table-rows

📝 Commits (1)

dc28c0d fix(markdown): only skip incomplete rows in streaming tables

📊 Changes

2 files changed (+49 additions, -5 deletions)

View changed files

📝 packages/core/src/renderables/Markdown.ts (+21 -5)
📝 packages/core/src/renderables/__tests__/Markdown.test.ts (+28 -0)

📄 Description

Split from #597 to make review easier.

Previously the last table row was always skipped during streaming, even when complete. Now checks if table.raw.endsWith("\n") — if yes, the row is complete and shown. Extracts getTableRowsToRender() and getTableRenderableRowCount() helpers.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/695 **Author:** [@remorses](https://github.com/remorses) **Created:** 2/16/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/markdown-streaming-table-rows` --- ### 📝 Commits (1) - [`dc28c0d`](https://github.com/anomalyco/opentui/commit/dc28c0d431b75dd38ba5acf7d486d46d130cc2e8) fix(markdown): only skip incomplete rows in streaming tables ### 📊 Changes **2 files changed** (+49 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/core/src/renderables/Markdown.ts` (+21 -5) 📝 `packages/core/src/renderables/__tests__/Markdown.test.ts` (+28 -0) </details> ### 📄 Description Split from #597 to make review easier. Previously the last table row was always skipped during streaming, even when complete. Now checks if `table.raw.endsWith("\n")` — if yes, the row is complete and shown. Extracts `getTableRowsToRender()` and `getTableRenderableRowCount()` helpers. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>