[PR #508] [MERGED] Fix(solid/examples): line-number-demo type errors and hidden header #586

New issue

Closed

opened 2026-03-02 23:47:14 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 23:47:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/anomalyco/opentui/pull/508
Author: @jhroemer
Created: 1/10/2026
Status: ✅ Merged
Merged: 1/11/2026
Merged by: @kommander

Base: main ← Head: fix-solid-examples-line-number-demo

📝 Commits (3)

1143719 Fix type issues
a2341bd Make sure header is not hidden in keybindings section
16090e3 Merge branch 'main' into fix-solid-examples-line-number-demo

📊 Changes

1 file changed (+13 additions, -13 deletions)

View changed files

📝 packages/solid/examples/components/line-number-demo.tsx (+13 -13)

📄 Description

Few type errors:

Using strings instead of RGBA for the style definitions
Using nonexistent bold prop on text component - changed to using attributes prop and TextAttributes

Additionally:
The "Line numbers demo" header wasn't showing when I was testing. Its container seems to be squashed by the other content. Fixed by not allowing it to shrink.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/anomalyco/opentui/pull/508 **Author:** [@jhroemer](https://github.com/jhroemer) **Created:** 1/10/2026 **Status:** ✅ Merged **Merged:** 1/11/2026 **Merged by:** [@kommander](https://github.com/kommander) **Base:** `main` ← **Head:** `fix-solid-examples-line-number-demo` --- ### 📝 Commits (3) - [`1143719`](https://github.com/anomalyco/opentui/commit/1143719ff70bbffa7c6d096c7f1a9bd62558f5e3) Fix type issues - [`a2341bd`](https://github.com/anomalyco/opentui/commit/a2341bd2b71f20c14e57a73b87f26ca9f8134abc) Make sure header is not hidden in keybindings section - [`16090e3`](https://github.com/anomalyco/opentui/commit/16090e35a0b7d05dbcbe326066f97edcc20b49b5) Merge branch 'main' into fix-solid-examples-line-number-demo ### 📊 Changes **1 file changed** (+13 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `packages/solid/examples/components/line-number-demo.tsx` (+13 -13) </details> ### 📄 Description Few type errors: - Using strings instead of `RGBA` for the style definitions - Using nonexistent `bold` prop on `text` component - changed to using `attributes` prop and `TextAttributes` Additionally: The "Line numbers demo" header wasn't showing when I was testing. Its container seems to be squashed by the other content. Fixed by not allowing it to shrink. <img width="1700" height="1344" alt="line-numbers-demo" src="https://github.com/user-attachments/assets/443db726-85cc-4fdd-a59a-8c39d73f6096" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>